Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[now-cli][now-client] Change `forceNewWithCache` to `withCache` #3966

Merged
merged 3 commits into from Mar 30, 2020

Conversation

@rdev
Copy link
Member

rdev commented Mar 25, 2020

Follow up to #3953 that makes the flag composable

@rdev rdev requested a review from AndyBitz Mar 25, 2020
@rdev rdev requested review from leo and TooTallNate as code owners Mar 25, 2020
@codecov

This comment has been minimized.

Copy link

codecov bot commented Mar 25, 2020

Codecov Report

Merging #3966 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3966      +/-   ##
==========================================
- Coverage   14.49%   14.48%   -0.02%     
==========================================
  Files         278      278              
  Lines       10083    10079       -4     
  Branches     1254     1255       +1     
==========================================
- Hits         1462     1460       -2     
+ Misses       8543     8541       -2     
  Partials       78       78              
Impacted Files Coverage Δ
src/util/metrics.ts 72.22% <0.00%> (+4.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0fd098...0be6631. Read the comment docs.

@rdev rdev added the automerge label Mar 26, 2020
@styfle styfle changed the title Change `forceNewWithCache` to `withCache` [now-cli][now-client] Change `forceNewWithCache` to `withCache` Mar 27, 2020
@kodiakhq kodiakhq bot merged commit 399a3cd into master Mar 30, 2020
15 checks passed
15 checks passed
CLI (ubuntu-latest, 10)
Details
Dev (ubuntu-latest, 10)
Details
E2E
Details
Unit (ubuntu-latest, 10)
Details
CLI (ubuntu-latest, 12)
Details
Dev (ubuntu-latest, 12)
Details
Unit (ubuntu-latest, 12)
Details
Dev (macos-latest, 10)
Details
Unit (macos-latest, 10)
Details
Dev (macos-latest, 12)
Details
Unit (macos-latest, 12)
Details
Unit (windows-latest, 10)
Details
Unit (windows-latest, 12)
Details
kodiakhq: status ⛴ attempting to merge PR (merging)
Details
now Deployment has completed
Details
@kodiakhq kodiakhq bot deleted the add/with-cache branch Mar 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.