Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[examples][now-static-build] Bump `ionic-react` to latest typescript #3967

Merged
merged 1 commit into from Mar 25, 2020

Conversation

@styfle
Copy link
Member

styfle commented Mar 25, 2020

Fixes an issue with a dependency that was bumped but typescript was pinned in ionic-react.

$ react-scripts build
Creating an optimized production build...
Failed to compile.
/zeit/333ecfab/node_modules/@types/testing-library__react/node_modules/pretty-format/build/index.d.ts
TypeScript error in /zeit/333ecfab/node_modules/@types/testing-library__react/node_modules/pretty-format/build/index.d.ts(7,13):
'=' expected.  TS1005
     5 |  * LICENSE file in the root directory of this source tree.
     6 |  */
  >  7 | import type * as PrettyFormat from './types';
       |             ^
     8 | /**
     9 |  * Returns a presentation string of your `val` object
    10 |  * @param val any potential JavaScript object
error Command failed with exit code 1.
@styfle styfle requested a review from AndyBitz Mar 25, 2020
@styfle styfle requested review from msweeneydev and timothyis as code owners Mar 25, 2020
@styfle styfle added the automerge label Mar 25, 2020
@codecov

This comment has been minimized.

Copy link

codecov bot commented Mar 25, 2020

Codecov Report

Merging #3967 into master will increase coverage by 0.54%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3967      +/-   ##
==========================================
+ Coverage   13.22%   13.76%   +0.54%     
==========================================
  Files         278      278              
  Lines        9982     9982              
  Branches     1285     1285              
==========================================
+ Hits         1320     1374      +54     
+ Misses       8578     8520      -58     
- Partials       84       88       +4     
Impacted Files Coverage Δ
src/util/dev/builder.ts 74.53% <0.00%> (-1.87%) ⬇️
src/util/dev/builder-cache.ts 83.76% <0.00%> (+1.29%) ⬆️
src/util/dev/server.ts 55.97% <0.00%> (+5.71%) ⬆️
src/util/dev/errors.ts 60.00% <0.00%> (+10.00%) ⬆️
src/util/dev/static-builder.ts 100.00% <0.00%> (+26.92%) ⬆️
src/util/dev/parse-listen.ts 85.00% <0.00%> (+70.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec917ac...b3d97ea. Read the comment docs.

@kodiakhq kodiakhq bot merged commit 400a5c7 into master Mar 25, 2020
16 checks passed
16 checks passed
CLI (ubuntu-latest, 10)
Details
Cancel Previous Runs
Details
Dev (ubuntu-latest, 10)
Details
E2E
Details
Unit (ubuntu-latest, 10)
Details
CLI (ubuntu-latest, 12)
Details
Dev (ubuntu-latest, 12)
Details
Unit (ubuntu-latest, 12)
Details
Dev (macos-latest, 10)
Details
Unit (macos-latest, 10)
Details
Dev (macos-latest, 12)
Details
Unit (macos-latest, 12)
Details
Unit (windows-latest, 10)
Details
Unit (windows-latest, 12)
Details
kodiakhq: status ⛴ attempting to merge PR (merging)
Details
now Deployment has completed
Details
@kodiakhq kodiakhq bot deleted the fix-50-ionic-react branch Mar 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.