Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

08 #5

Merged
merged 7 commits into from Dec 10, 2019
Merged

08 #5

merged 7 commits into from Dec 10, 2019

Conversation

@zeitschlag
Copy link
Owner

zeitschlag commented Dec 9, 2019

No description provided.

Copy link

klyonrad left a comment

not really actionable feedback: try to avoid loops that are so deeply nested

2019/08/8.rb Outdated Show resolved Hide resolved
2019/08/8.rb Outdated Show resolved Hide resolved
2019/08/8.rb Outdated Show resolved Hide resolved
2019/08/8.rb Outdated Show resolved Hide resolved
@zeitschlag

This comment has been minimized.

Copy link
Owner Author

zeitschlag commented Dec 10, 2019

Again: Thanks a lot for your feedback, @klyonrad! I really appreciate it. tbh: Nested loops don't feel right to me most of the time. But still, they're my first idea and most of the time, it just works. As you pointed it out, I will try to have a better look at this.

@zeitschlag zeitschlag merged commit 2454c70 into master Dec 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.