New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trouble compiling with node-gyp #3

Closed
felixmc opened this Issue Jan 17, 2016 · 9 comments

Comments

Projects
None yet
5 participants
@felixmc
Contributor

felixmc commented Jan 17, 2016

I have a Raspberry Pi 2 Model B running latest Raspbian, Node.js v4.2.2, and node-gyp v3.2.1

When I try installing node-rpi-rgb-led-matrix via npm I get the following error: https://www.dropbox.com/s/5vbfcsa38wffwwo/Screenshot%202016-01-17%2012.31.16.png?dl=0

Here is the associated npm-debug.log: http://pastebin.com/mBr7AGP2

Afterwards I tried cloning the project in node_modules and building it manually with node-gyp, but it failed again with a different error code. Here's what the output looked like: https://www.dropbox.com/s/jhus8ciayk08kce/Screenshot%202016-01-17%2012.38.21.png?dl=0

Seems like it might be a problem with the project, but it could also be something specific to my environment. Let me know if there's anything I can do to help resolve this!

@phuongvu

This comment has been minimized.

Show comment
Hide comment
@phuongvu

phuongvu Jan 17, 2016

You might want to downgrade your Node to v0.10.x.

phuongvu commented Jan 17, 2016

You might want to downgrade your Node to v0.10.x.

@felixmc

This comment has been minimized.

Show comment
Hide comment
@felixmc

felixmc Jan 18, 2016

Contributor

@phuongvu thank you! after downgrading node to v0.10.x the package works via both node-gyp and npm install.

Perhaps this dependency should be expressed in the README as well as package.json with something like { "engines" : { "node" : ">=0.10.3 <0.12" } }

Contributor

felixmc commented Jan 18, 2016

@phuongvu thank you! after downgrading node to v0.10.x the package works via both node-gyp and npm install.

Perhaps this dependency should be expressed in the README as well as package.json with something like { "engines" : { "node" : ">=0.10.3 <0.12" } }

@phuongvu

This comment has been minimized.

Show comment
Hide comment
@phuongvu

phuongvu Jan 18, 2016

@felixmc I think there is a need for updating the code so that it works with node v0.12, v4 and v5. The API changes for native addons introduced in v0.12.x and the newer versions break the build. @zeitungen would be great if you can give us some feedback 👍

https://nodejs.org/api/addons.html
https://strongloop.com/strongblog/node-js-v0-12-c-apis-breaking/

phuongvu commented Jan 18, 2016

@felixmc I think there is a need for updating the code so that it works with node v0.12, v4 and v5. The API changes for native addons introduced in v0.12.x and the newer versions break the build. @zeitungen would be great if you can give us some feedback 👍

https://nodejs.org/api/addons.html
https://strongloop.com/strongblog/node-js-v0-12-c-apis-breaking/

@zeitungen

This comment has been minimized.

Show comment
Hide comment
@zeitungen

zeitungen Jan 18, 2016

Owner

Thanks for the feedback !
I only try with node 0.10.x because my environnement require for now the 0.10.x (hello http://timesquair.io/).
But I guess, I can, or something else, start to adapt this to node > 0.10.x and see if it can keep retrocompatibility to 0.10.x.

Owner

zeitungen commented Jan 18, 2016

Thanks for the feedback !
I only try with node 0.10.x because my environnement require for now the 0.10.x (hello http://timesquair.io/).
But I guess, I can, or something else, start to adapt this to node > 0.10.x and see if it can keep retrocompatibility to 0.10.x.

@sebleedelisle

This comment has been minimized.

Show comment
Hide comment
@sebleedelisle

sebleedelisle Jan 28, 2016

Contributor

I've actually got this code working with node 5.4.1 but obviously this breaks in older versions. I'll take a look at implementing NAN - if it's easy then I'll do it and PR. Thanks for a great library!

Contributor

sebleedelisle commented Jan 28, 2016

I've actually got this code working with node 5.4.1 but obviously this breaks in older versions. I'll take a look at implementing NAN - if it's easy then I'll do it and PR. Thanks for a great library!

@zeitungen

This comment has been minimized.

Show comment
Hide comment
@zeitungen

zeitungen Jan 31, 2016

Owner

I've merged PR from @sebleedelisle, now, you can run this module with nodejs >0.10.x.
Please, give me some feedback about this new updates. If no problem, I'll update the npm package and publish new one.

Owner

zeitungen commented Jan 31, 2016

I've merged PR from @sebleedelisle, now, you can run this module with nodejs >0.10.x.
Please, give me some feedback about this new updates. If no problem, I'll update the npm package and publish new one.

@pfrazee

This comment has been minimized.

Show comment
Hide comment
@pfrazee

pfrazee Feb 3, 2016

I had the original issue. I checked out the repo to get latest, and it worked for me 👍

pfrazee commented Feb 3, 2016

I had the original issue. I checked out the repo to get latest, and it worked for me 👍

@zeitungen

This comment has been minimized.

Show comment
Hide comment
@zeitungen

zeitungen Feb 22, 2016

Owner

I think if nobody else report a problem on this issue, I can close it.
Thanks again for feedbacks.

Owner

zeitungen commented Feb 22, 2016

I think if nobody else report a problem on this issue, I can close it.
Thanks again for feedbacks.

@zeitungen zeitungen closed this Feb 22, 2016

@sebleedelisle

This comment has been minimized.

Show comment
Hide comment
@sebleedelisle

sebleedelisle Feb 22, 2016

Contributor

Thanks Maxime!

On 22 February 2016 at 14:32, Maxime Journaux notifications@github.com
wrote:

I think if nobody else report a problem on this issue, I can close it.
Thanks again for feedbacks.


Reply to this email directly or view it on GitHub
#3 (comment)
.

Contributor

sebleedelisle commented Feb 22, 2016

Thanks Maxime!

On 22 February 2016 at 14:32, Maxime Journaux notifications@github.com
wrote:

I think if nobody else report a problem on this issue, I can close it.
Thanks again for feedbacks.


Reply to this email directly or view it on GitHub
#3 (comment)
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment