New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated to use Nan and multiple versions of Node.js up to 5 #6

Merged
merged 6 commits into from Jan 31, 2016

Conversation

Projects
None yet
2 participants
@sebleedelisle
Contributor

sebleedelisle commented Jan 30, 2016

Rewritten in the style recommended in https://github.com/nodejs/node-addon-examples for Nan (https://github.com/nodejs/nan) so should be good for versions 0.8, 0.10, 0.12, 4 and 5.

Tested with :
0.10.29 - works, but requires fix outlined in Readme
0.12.6
5.4.2

zeitungen added a commit that referenced this pull request Jan 31, 2016

Merge pull request #6 from sebleedelisle/master
Updated to use Nan and multiple versions of Node.js up to 5

@zeitungen zeitungen merged commit ff04d57 into zeitungen:master Jan 31, 2016

@zeitungen

This comment has been minimized.

Show comment
Hide comment
@zeitungen

zeitungen Jan 31, 2016

Owner

Awesome !
I've test it with my node 0.10.40. No problem.
Thanks for the PR !

Owner

zeitungen commented Jan 31, 2016

Awesome !
I've test it with my node 0.10.40. No problem.
Thanks for the PR !

@sebleedelisle

This comment has been minimized.

Show comment
Hide comment
@sebleedelisle

sebleedelisle Jan 31, 2016

Contributor

That's very encouraging! :)

On Sun, Jan 31, 2016 at 11:18 AM, Maxime Journaux notifications@github.com
wrote:

Awesome !
I've test it with my node 0.10.40. No problem.
Thanks for the PR !


Reply to this email directly or view it on GitHub
#6 (comment)
.

Contributor

sebleedelisle commented Jan 31, 2016

That's very encouraging! :)

On Sun, Jan 31, 2016 at 11:18 AM, Maxime Journaux notifications@github.com
wrote:

Awesome !
I've test it with my node 0.10.40. No problem.
Thanks for the PR !


Reply to this email directly or view it on GitHub
#6 (comment)
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment