Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sketchinn drawings still shown in screenshot. #9

Open
GoogleCodeExporter opened this issue Dec 30, 2015 · 4 comments
Open

Sketchinn drawings still shown in screenshot. #9

GoogleCodeExporter opened this issue Dec 30, 2015 · 4 comments

Comments

@GoogleCodeExporter
Copy link

What steps will reproduce the problem?
1.Open sketch
2.Draw something
3.Open Screenshot

What is the expected output? What do you see instead?
A clear screenshot page is expected; however it shows the things coming from 
sketch.

Original issue reported on code.google.com by utkusi...@gmail.com on 23 Mar 2011 at 5:17

@GoogleCodeExporter
Copy link
Author

This is due to the way sketching is currently implemented, it's done via 
AnnotationWidget which has context recall and thus reloads the last drawings. 
To fix this, we need to move sketching to its own widget (SketchingWidget, 
derived from BaseDrawingWidget) and display this widget instead of 
AnnotationWidget when sketching is selected from the menu. This will require 
some UI refactoring for MainWindow so let's keep it like this for the moment.

Original comment by malta...@gmail.com on 23 Mar 2011 at 5:24

@GoogleCodeExporter
Copy link
Author

r85, This problem has been fixed just fixing a little bug in the program. 
SketchingWidget will be the upcoming step after discussing its necessity.

Original comment by utkusi...@gmail.com on 30 Mar 2011 at 3:45

@GoogleCodeExporter
Copy link
Author

SketchinWidget decided to be integrated to the system as it is required by SDD. 
Working on it.

Original comment by utkusi...@gmail.com on 31 Mar 2011 at 7:46

@GoogleCodeExporter
Copy link
Author

r86, sketching component has been constructed. Some basic changes and logics 
applied is the following

1 - A new object named SketchingWidget.cpp is created. This a new class derived 
from BaseDrawingClass. 

2 - A new QWidget variable named groupForSketching is created. This is to group 
the objects of SketchingWidget and the Qlabel that holds the pixels of blank 
image or screeshot

3 - Old variable named group(AnnotationWidget object) 's name changed as 
"groupForPresentation".

4 - A new variable named "stackWidget" is introduced. This is a QStackedWidget 
object and keeps two widgets groupForPresentation and groupForSketching. As 
stack provide us having one of the widget is active at the same time, these 
widgets are used alternatively by the lines

widgetStack->setCurrentIndex(ANNOTATION_WIDGET);
widgetStack->setCurrentIndex(SKETCHING_WIDGET);

in the required places.

5 - Due to the state diagram attached to the note, there are two 
sketchingwidget component. One is to keep sketched data one is to keep 
screenshot data. Indeed, It is only for "open existing sketch" option. We have 
to keep sketching's drawing data seperate from the screenshot drawingdata in 
order not to destroy sketching's drawing data when we load a screenshot image. 

Note that only one sketchingwidget is visible at a time.

6 - mainwindow constructor, openNewSketch(), openExistingSketch() and 
openScreenshot() functions can be examined for the changes.









Original comment by utkusi...@gmail.com on 2 Apr 2011 at 10:45

Attachments:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant