Željko Filipin zeljkofilipin

Organizations

@wikimedia @watir
@zeljkofilipin
  • @zeljkofilipin fac79e5
    Move this repo to the end of .mrconfig
@zeljkofilipin
@zeljkofilipin
@zeljkofilipin
  • @zeljkofilipin c12578a
    Add page-object-minimal repo to mrconfig
@zeljkofilipin
  • @zeljkofilipin 3f12dc7
    Added Amir's repos to .mrconfig
@zeljkofilipin

@p0deje rubicon?

@zeljkofilipin

RuboCop can convert hashes from old syntax to the new one automatically.

@zeljkofilipin

:+1:

@zeljkofilipin
zeljkofilipin merged pull request amire80/screenshot#11
@zeljkofilipin
Add padding support
1 commit with 17 additions and 7 deletions
@zeljkofilipin
zeljkofilipin merged pull request amire80/screenshot#10
@zeljkofilipin
Remove offset support
1 commit with 3 additions and 8 deletions
@zeljkofilipin
zeljkofilipin merged pull request amire80/screenshot#9
@zeljkofilipin
Remove iframe support
1 commit with 2 additions and 14 deletions
@zeljkofilipin
  • @zeljkofilipin a95c45f
    Renamed JJB folders to be the same as in Jenkins
@zeljkofilipin
  • @zeljkofilipin 7dbc256
    Do not install mediawiki_selenium every time
@zeljkofilipin
  • @zeljkofilipin 07a5b14
    Display absolute line numbers on the left in Vim
zeljkofilipin commented on pull request wmde/WikidataBrowserTests#57
@zeljkofilipin

Sorry, I was reviewing the code on a small 11 inch screen, and looks like github does not display diffs correctly in some cases, indenting looked c…

zeljkofilipin commented on pull request wmde/WikidataBrowserTests#65
@zeljkofilipin

:+1:

zeljkofilipin commented on pull request wmde/WikidataBrowserTests#63
@zeljkofilipin

:+1:

zeljkofilipin commented on pull request wmde/WikidataBrowserTests#62
@zeljkofilipin

:+1:

zeljkofilipin commented on pull request wmde/WikidataBrowserTests#64
@zeljkofilipin

:+1: I did not even know page-object (I guess) introduces those keywords.

zeljkofilipin commented on pull request wmde/WikidataBrowserTests#60
@zeljkofilipin

Just a note, to_not can be replaced with not_to. I think it makes the code more readable, but it is optional.

zeljkofilipin commented on pull request wmde/WikidataBrowserTests#59
@zeljkofilipin

:+1:

zeljkofilipin commented on pull request wmde/WikidataBrowserTests#58
@zeljkofilipin

:+1:

zeljkofilipin commented on pull request wmde/WikidataBrowserTests#1
@zeljkofilipin

You can dynamically call a method. Something like: @memorized = on(ItemPage).send("entity_selector_input#{second}_element").attribute_value("value")

zeljkofilipin commented on pull request wmde/WikidataBrowserTests#1
@zeljkofilipin

I think to.be == @memorized could be to eq @memorized

zeljkofilipin commented on pull request wmde/WikidataBrowserTests#1
@zeljkofilipin

Why aren't you waiting for something on the page to happen, instead of hardcoding sleep?