fix: touch and trackpad support for image diff slider#24
Open
zelon wants to merge 1 commit into
Open
Conversation
Replaces onMouseDown/mousemove/mouseup with the Pointer Events API so that the slider and pan interactions work on touch screens and trackpads, not just mouse input. Changes: - onSliderMouseDown → onSliderPointerDown (React.PointerEvent) - onPanMouseDown → onPanPointerDown, guards on pointerType instead of button - Global mousemove/mouseup listeners → pointermove/pointerup - setPointerCapture on drag start to keep events routed correctly - touch-action: none on draggable elements to prevent browser scroll interference Closes #20 https://claude.ai/code/session_01VLHEkn9xkvhAhyRYHRrtFw
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces
MouseEventlisteners with the Pointer Events API inImageDiffViewer, enabling the slider and pan interactions to work on touch screens and trackpads in addition to mouse input.Closes #20
Changes
onSliderMouseDown→onSliderPointerDown(React.PointerEvent)onPanMouseDown→onPanPointerDown; left-button guard changed frome.button !== 0toe.pointerType === "mouse" && e.button !== 0so touch input is not blockedmousemove/mouseupwindow listeners →pointermove/pointerupsetPointerCaptureon drag start so events stay routed to the correct element even when the pointer moves outside ittouch-action: noneon all draggable elements to prevent the browser from intercepting touch gestures as scrollTest plan
https://claude.ai/code/session_01VLHEkn9xkvhAhyRYHRrtFw
Generated by Claude Code