Skip to content

Add support for JSON and Streams on the parseAsync method #377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
knownasilya merged 1 commit into from
Apr 3, 2019
Merged

Add support for JSON and Streams on the parseAsync method #377

knownasilya merged 1 commit into from
Apr 3, 2019

Conversation

@juanjoDiaz
Copy link
Collaborator

@juanjoDiaz juanjoDiaz commented Apr 1, 2019

I realized that the asyncParse method only works for JSON and only providing the objectMode flag.

With this change, it accepts both JSON and streams and intelligently selects the stream mode.

@coveralls
Copy link

coveralls commented Apr 1, 2019

Coverage Status

Coverage remained the same at 100.0% when pulling 1504471 on juanjoDiaz:improve_async_parser into d56c752 on zemirco:master.

2 similar comments
@coveralls
Copy link

coveralls commented Apr 1, 2019

Coverage Status

Coverage remained the same at 100.0% when pulling 1504471 on juanjoDiaz:improve_async_parser into d56c752 on zemirco:master.

@coveralls
Copy link

coveralls commented Apr 1, 2019

Coverage Status

Coverage remained the same at 100.0% when pulling 1504471 on juanjoDiaz:improve_async_parser into d56c752 on zemirco:master.

@knownasilya knownasilya merged commit de296d3 into zemirco:master Apr 3, 2019
@juanjoDiaz juanjoDiaz deleted the improve_async_parser branch April 29, 2019 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@juanjoDiaz @coveralls @knownasilya