no-bug: added tests for unloading all other workspaces#13100
Merged
Conversation
dosubot
Bot
added
the
size:L
mr-cheffy
requested changes
Apr 5, 2026
| ok(tab.linkedPanel, "Tab should have linked panel before unload"); | ||
| } | ||
|
|
||
| await gZenWorkspaces.unloadAllOtherWorkspaces(); |
Member
There was a problem hiding this comment.
Shouldn't you switch to the original space first? Or maybe switch, create the tabs, switch back?
Contributor
Author
There was a problem hiding this comment.
Not sure I'm getting what you mean. Are you saying I should create the tabs in the new Test Workspace, then switch back to the default one and call unload?
mr-cheffy
changed the title
mr-cheffy
approved these changes
Apr 7, 2026
mr-cheffy
requested changes
Apr 7, 2026
mr-cheffy
requested changes
Apr 8, 2026
AfeefurR
force-pushed
the
unload-spaces-test
branch
from
b0da590 to
f7df42b
Compare
Contributor
Author
|
Not directly related, but the |
mr-cheffy
approved these changes
Apr 8, 2026
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added tests for
gZenWorkspaces.unloadAllOtherWorkspaces()Verifies
Reference #12751