Skip to content


Subversion checkout URL

You can clone with
Download ZIP
Browse files

apparmor: fix IRQ stack overflow during free_profile


Profile replacement can cause long chains of profiles to build up when
the profile being replaced is pinned. When the pinned profile is finally
freed, it puts the reference to its replacement, which may in turn nest
another call to free_profile on the stack. Because this may happen for
each profile in the replacedby chain this can result in a recusion that
causes the stack to overflow.

Break this nesting by directly walking the chain of replacedby profiles
(ie. use iteration instead of recursion to free the list). This results
in at most 2 levels of free_profile being called, while freeing a
replacedby chain.

Signed-off-by: John Johansen <>
Signed-off-by: James Morris <>
  • Loading branch information...
commit 2e680dd61e80592385338bfbeb86833d1c60546c 1 parent 0e9e3e3
John Johansen authored James Morris committed
Showing with 23 additions and 1 deletion.
  1. +23 −1 security/apparmor/policy.c
24 security/apparmor/policy.c
@@ -724,6 +724,8 @@ struct aa_profile *aa_new_null_profile(struct aa_profile *parent, int hat)
static void free_profile(struct aa_profile *profile)
+ struct aa_profile *p;
AA_DEBUG("%s(%p)\n", __func__, profile);
if (!profile)
@@ -751,7 +753,27 @@ static void free_profile(struct aa_profile *profile)
- aa_put_profile(profile->replacedby);
+ /* put the profile reference for replacedby, but not via
+ * put_profile(kref_put).
+ * replacedby can form a long chain that can result in cascading
+ * frees that blows the stack because kref_put makes a nested fn
+ * call (it looks like recursion, with free_profile calling
+ * free_profile) for each profile in the chain lp#1056078.
+ */
+ for (p = profile->replacedby; p; ) {
+ if (atomic_dec_and_test(&p->base.count.refcount)) {
+ /* no more refs on p, grab its replacedby */
+ struct aa_profile *next = p->replacedby;
+ /* break the chain */
+ p->replacedby = NULL;
+ /* now free p, chain is broken */
+ free_profile(p);
+ /* follow up with next profile in the chain */
+ p = next;
+ } else
+ break;
+ }
Please sign in to comment.
Something went wrong with that request. Please try again.