From 6bc5a62f62197b14060ce35c2dab7e831658aede Mon Sep 17 00:00:00 2001
From: Scott C Wilson <scottcwilson@gmail.com>
Date: Thu, 20 Dec 2018 08:30:53 -0500
Subject: [PATCH] Ensure OT statuses are defined before checking value

---
 includes/modules/sideboxes/information.php                  | 4 ++--
 .../templates/tpl_modules_mobile_menu.php                   | 4 ++--
 .../template_default/templates/tpl_site_map_default.php     | 6 +++---
 3 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/includes/modules/sideboxes/information.php b/includes/modules/sideboxes/information.php
index 9d725d1d2b..edc1cce84f 100644
--- a/includes/modules/sideboxes/information.php
+++ b/includes/modules/sideboxes/information.php
@@ -34,11 +34,11 @@
   }
 
   // only show GV FAQ when installed
-  if (MODULE_ORDER_TOTAL_GV_STATUS == 'true') {
+  if (defined('MODULE_ORDER_TOTAL_GV_STATUS') && MODULE_ORDER_TOTAL_GV_STATUS == 'true') {
     $information[] = '<a href="' . zen_href_link(FILENAME_GV_FAQ) . '">' . BOX_INFORMATION_GV . '</a>';
   }
   // only show Discount Coupon FAQ when installed
-  if (DEFINE_DISCOUNT_COUPON_STATUS <= 1 && MODULE_ORDER_TOTAL_COUPON_STATUS == 'true') {
+  if (DEFINE_DISCOUNT_COUPON_STATUS <= 1 && defined('MODULE_ORDER_TOTAL_COUPON_STATUS') && MODULE_ORDER_TOTAL_COUPON_STATUS == 'true') {
     $information[] = '<a href="' . zen_href_link(FILENAME_DISCOUNT_COUPON) . '">' . BOX_INFORMATION_DISCOUNT_COUPONS . '</a>';
   }
 
diff --git a/includes/templates/responsive_classic/templates/tpl_modules_mobile_menu.php b/includes/templates/responsive_classic/templates/tpl_modules_mobile_menu.php
index 5b6d86ef5e..511909ad57 100644
--- a/includes/templates/responsive_classic/templates/tpl_modules_mobile_menu.php
+++ b/includes/templates/responsive_classic/templates/tpl_modules_mobile_menu.php
@@ -101,10 +101,10 @@
 <?php if (DEFINE_SITE_MAP_STATUS <= 1) { ?>
         <li><a href="<?php echo zen_href_link(FILENAME_SITE_MAP); ?>"><?php echo BOX_INFORMATION_SITE_MAP; ?></a></li>
 <?php } ?>
-<?php if (MODULE_ORDER_TOTAL_GV_STATUS == 'true') { ?>
+<?php if (defined('MODULE_ORDER_TOTAL_GV_STATUS') && MODULE_ORDER_TOTAL_GV_STATUS == 'true') { ?>
         <li><a href="<?php echo zen_href_link(FILENAME_GV_FAQ); ?>"><?php echo BOX_INFORMATION_GV; ?></a></li>
 <?php } ?>
-<?php if (DEFINE_DISCOUNT_COUPON_STATUS <= 1 && MODULE_ORDER_TOTAL_COUPON_STATUS == 'true') { ?>
+<?php if (DEFINE_DISCOUNT_COUPON_STATUS <= 1 && defined('MODULE_ORDER_TOTAL_COUPON_STATUS') && MODULE_ORDER_TOTAL_COUPON_STATUS == 'true') { ?>
         <li><a href="<?php echo zen_href_link(FILENAME_DISCOUNT_COUPON); ?>"><?php echo BOX_INFORMATION_DISCOUNT_COUPONS; ?></a></li>
 <?php } ?>
 <?php if (SHOW_NEWSLETTER_UNSUBSCRIBE_LINK == 'true') { ?>
diff --git a/includes/templates/template_default/templates/tpl_site_map_default.php b/includes/templates/template_default/templates/tpl_site_map_default.php
index d1f8070be1..8fb8ef7f36 100644
--- a/includes/templates/template_default/templates/tpl_site_map_default.php
+++ b/includes/templates/template_default/templates/tpl_site_map_default.php
@@ -61,10 +61,10 @@
 <?php if (!empty($external_bb_url) && !empty($external_bb_text)) { ?>
             <li><?php echo '<a href="' . $external_bb_url . '" target="_blank">' . $external_bb_text . '</a>'; ?></li>
 <?php } ?>
-<?php if (MODULE_ORDER_TOTAL_GV_STATUS == 'true') { ?>
+<?php if (defined('MODULE_ORDER_TOTAL_GV_STATUS') && MODULE_ORDER_TOTAL_GV_STATUS == 'true') { ?>
             <li><?php echo '<a href="' . zen_href_link(FILENAME_GV_FAQ) . '">' . BOX_INFORMATION_GV . '</a>'; ?></li>
 <?php } ?>
-<?php if (MODULE_ORDER_TOTAL_COUPON_STATUS == 'true') { ?>
+<?php if (defined('MODULE_ORDER_TOTAL_COUPON_STATUS') && MODULE_ORDER_TOTAL_COUPON_STATUS == 'true') { ?>
             <li><?php echo '<a href="' . zen_href_link(FILENAME_DISCOUNT_COUPON) . '">' . BOX_INFORMATION_DISCOUNT_COUPONS . '</a>'; ?></li>
 <?php } ?>
 <?php if (SHOW_NEWSLETTER_UNSUBSCRIBE_LINK == 'true') { ?>
@@ -85,4 +85,4 @@
 </div>
 <br class="clearBoth" />
 <div class="buttonRow back"><?php echo zen_back_link() . zen_image_button(BUTTON_IMAGE_BACK, BUTTON_BACK_ALT) . '</a>'; ?></div>
-</div>
\ No newline at end of file
+</div>