Permalink
Commits on Apr 26, 2012
  1. Add option to generate RSpec via rspec-puppet (-R).

    Add option to exclude RSpec tests (-X).
    committed Apr 26, 2012
Commits on Jan 22, 2012
Commits on Jan 21, 2012
Commits on Dec 29, 2011
  1. Merge pull request #17 from zsprackett/master

    Add gitignore to default puppet module
    jeffmccune committed Dec 29, 2011
Commits on Dec 28, 2011
  1. Add gitignore to default puppet module

    Many people using this tool are checking files into git and are not good
    at housekeeping.  Lots of modules have editor temp files stored in their
    git repos.  This patch adds some magic that will rename files starting with
    _ to dotfiles in the target directory.
    zsprackett committed Dec 24, 2011
Commits on Dec 7, 2011
  1. Merge pull request #14 from domcleal/tickets/master/11151

    (#11151) Fix attempted connection to "none" HTTP proxy
    Matt Robinson committed Dec 7, 2011
Commits on Dec 3, 2011
  1. (#11151) Fix attempted connection to "none" HTTP proxy

    Handle the default Puppet HTTP proxy hostname being the string "none".
    domcleal committed Dec 3, 2011
Commits on Dec 2, 2011
  1. Fix URI paths to allow specs to pass when run from a dir with spaces

    Jenkins tends to have spaces in the path into which it checks out repos, and that was causing failures:
    
        bad URI(is not URI?): file:///Users/matthewrobinson/work/puppet module tool/tmp/spec/myuser-mymodule-0.0.1.tar.gz
    
    I'm really not sure why we're using URIs for file paths, but while we are we need to URI escape these paths, and then unescape them before using them.
    
    Reviewed-by: Nick Lewis <nick@puppetlabs.com>
    Matt Robinson committed Dec 2, 2011
Commits on Dec 1, 2011
  1. Merge pull request #13 from mmrobins/ticket/master/10438

    (#10438) Add install_dir to the command line
    nicklewis committed Dec 1, 2011
  2. (#10438) Add install_dir to the command line

    The previous commit for #10438 to have a configurable install dir forgot
    to put the command line option in.  This commit does that.
    
    It also adds some code to the spec helper to prevent the specs from
    interacting with puppet's actual vardir.  This was necessary to make the
    test for the install_dir option workable, and it's just a good thing
    besides.
    Matt Robinson committed Dec 1, 2011
  3. Merge pull request #11 from mmrobins/ticket/master/10438

    (#10438) Extract installed modules to the module path by default
    nicklewis committed Dec 1, 2011
  4. Factor out build_and_install_module

    The specs were duplicating a lot of setup.  This helps a little.
    Matt Robinson committed Dec 1, 2011
  5. (#10438) Extract installed modules to the module path by default

    The current behavior is to only allow the module to install to the
    current working directory.  This makes the install destination
    configurable both from inside your puppet.conf and from the command
    line.
    
    There were some concerns about the default being your module path.  Here
    are those concerns and why it was decided to default to the modulepath
    anyway.
    
    Objections
    * Installing directly to the module path in production may not be what
      you want.  However, just installing a module shouldn't do anything
      until you actually include it's classes in your manifests.
    * The modulepath might have more than one directory in it.  We just use
      the first one.  This will require a PE change so it's modulepath is
      useful for this assumption.
    * If you're want to download a module to develop it you don't want it in
      the module path.  I think if you want to develop a module you want to
      run it to test it also, and your modulepath will probably already be
      version controlled.
    
    Pros
    * One of the trickiest things for new users is installing modules to the
      right location, and this helps with that a lot.
    * Experienced users can configure whatever they want easily from the
      command line.
    
    There was some trickiness with getting the settings right from Puppet
    since you have to mess with the run_mode global setting and reparse the
    settings.  The code was already trying to use Puppet settings, but
    wasn't dealing with the run_mode correctly, so now the settings that
    were already defined should work too.
    Matt Robinson committed Nov 30, 2011
  6. Remove unecessary requirement checking of thor

    We already vendor thor, and if it's not present the text you get from
    the LoadError is sufficient to know what's going on without rescuing and
    supplying our own text.  In fact the default error message is better
    since it includes a stack trace.
    Matt Robinson committed Nov 30, 2011
Commits on Nov 30, 2011
  1. Remove all the trailing whitespace

    Matt Robinson committed Nov 30, 2011
Commits on Nov 26, 2011
  1. Merge pull request #10 from kbarber/ticket/4847-http_proxy

    (#4847) Add support for http_proxy environment variable for http requests
    jamtur01 committed Nov 26, 2011
Commits on Nov 22, 2011
  1. (#4847) Add support for http_proxy environment variable for http requ…

    …ests
    
    Previously we added support for using a HTTP proxy specific in puppet's
    configuration file. This patch adds support for the environment variable
    'http_proxy' as an override.
    
    This also fixes the broken tests for proxy support and gets rake spec working
    again as it should with rspec 2.7.x.
    kbarber committed Nov 22, 2011
Commits on Nov 3, 2011
  1. Merge pull request #9 from hakamadare/proxy_support

    use Net::HTTP::Proxy instead of Net::HTTP
    jeffmccune committed Nov 3, 2011
Commits on Oct 31, 2011
  1. use Net::HTTP::Proxy instead of Net::HTTP

    read http_proxy_host and http_proxy_port from Puppet's config
    
    if these configuration options are not set, no change in behavior
    hakamadare committed Oct 31, 2011
Commits on Oct 14, 2011
  1. Fixed fault test

    jamtur01 committed Oct 14, 2011
  2. Merge pull request #8 from johnf/tests-1.9.2

    Make tests work with rspec 2.0 and ruby 1.9.2
    jamtur01 committed Oct 14, 2011
Commits on Oct 10, 2011
  1. Make tests work with rspec 2.0

    johnf committed Oct 10, 2011
Commits on Aug 9, 2011
Commits on Jul 19, 2011
  1. Merge branch 'ticket/master/8506_cannot_install_modules_with_dashes'

    * ticket/master/8506_cannot_install_modules_with_dashes:
      (#8506) Add ability to install modules with hyphens
    jeffmccune committed Jul 19, 2011
  2. (#8506) Add ability to install modules with hyphens

    This change fixes the module filename parsing method to support module
    names with hyphens and dashes in them.
    
    Without this change the following module name was causing an error in
    the install action:
    
        puppetlabs-cloud-provisioner-0.0.1git-95-g6541187.tar.gz
    
    This error was caused by the module tool doing a simple split on the
    filename.  This change uses a more robust regular expression to parse
    the username, module name, and semantic version from the package
    filename.
    
    Reviewed-by: Dan Bode
    jeffmccune committed Jul 19, 2011
Commits on Jun 21, 2011
  1. Merge branch 'ticket/master/6_install_working_modules'

    closes #6
    closes #7
    
    * ticket/master/6_install_working_modules:
      (#6) Add check for symlink when installing
      (#6) Install modules to their name not "full name"
    
    Reviewed-by: Michael Stanhke <stahnma@puppetlabs.com>
    jeffmccune committed Jun 21, 2011
  2. (#6) Add check for symlink when installing

    When installing a module, File.exist? returns false for a dangling
    symbolic link.  The dangling symlink prevents the actual installation of
    the module form succeeding, however, which is the point of checking for
    existence of a file with the same name.
    
    This change adds an additional check to see if a symbolic link exists
    with the same name of the module we're installing.  Without this change,
    a backtrace error was being triggered.
    
    Reviewed-by: Michael Stanhke <stahnma@puppetlabs.com>
    jeffmccune committed Jun 21, 2011
  3. (#6) Install modules to their name not "full name"

    Without this change, the puppet-module tool installs modules into
    directories named of the format author-modulename.  This is problematic
    because the Puppet autoloader convention causes Puppet to expect a class
    named "mcollective" in a directory named "mcollective" in
    manifests/init.pp in the module.
    
    As a result, all modules should be installed into a directory with their
    specific module name, NOT a directory prefixed with the author of the
    module and a hyphen.
    
    This change replaces the use of the "full_name" with only the
    "module_name" instance variables in the Unpacker class.
    
    Reviewed-by: Michael Stanhke <stahnma@puppetlabs.com>
    jeffmccune committed Jun 21, 2011
  4. Merge pull request #5 from jeffmccune/ticket/master/4_semver_support

    Ticket/master/4 semver support
    jeffmccune committed Jun 21, 2011
Commits on Jun 16, 2011
  1. (#4) Add semver support rspec tests

    These unit tests validate a series of "good" version strings and
    properly handled and a series of "bad" version strings raise an error as
    expected.
    
    Run with rspec semver_spec.rb with rspec 2.5.1
    jeffmccune committed Jun 16, 2011
  2. (#4) Add semantic version support

    This change replaces the validation of the version string using
    Gem::Version.new() with a regular expression matching the semver.org
    description of versions.
    
    The reason for this change is that Gem::Version.new() is too restrictive
    and does not allow semantic version strings to be used.  We're trying to
    use semantic versions for modules and for development releases these may
    be in the form of 0.0.2git-8-g3d316d1
    
    Also changed the error message to indicate we support semantic versions and
    provide the end user a link to semver.org for more information.
    jeffmccune committed Jun 16, 2011
  3. Whitespace only cleanup

    jeffmccune committed Jun 16, 2011
Commits on May 6, 2011
  1. Merge pull request #2 from ody/tickets/master/7271

    (#7271) README.markdown should be removed
    jamtur01 committed May 6, 2011
Commits on Apr 28, 2011
  1. (#7271) README.markdown should be removed

      This fixes the mentioned bug by removing README.markdown files from the
      the puppet-module-tool template directoies.
    ody committed Apr 28, 2011
Commits on Apr 15, 2011
  1. Updated to v0.3.3

    jamtur01 committed Apr 15, 2011