Code refactoring in preparation for moving client state to radar server. #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- don't use the naked _me reference
- Identify APIs as public/private by
- prefixing with _ (e.g. _handleClientMessage) where appropriate
- regrouping of APIs in source files into public/private groups
- rename APIs where needed (all private APIs)
- expand comments minimally to clarify purpose of APIs
| @@ -21,7 +23,7 @@ function Server() { | |||
| this.subs = {}; | |||
| } | |||
|
|
|||
| MiniEventEmitter.mixin(Server); | |||
There was a problem hiding this comment.
probably better to leave it after Server definition
There was a problem hiding this comment.
It works fine either before or after, but I will standardize on putting it after the definition of the main class in the module, which in this case is Server.
|
馃憤 |
bolddane
added a commit
that referenced
this pull request
Mar 10, 2015
Code refactoring in preparation for moving client state to radar server.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @zendesk/zendesk-radar
Steps to merge
References
Risks