WIP server presence heartbeat using redis #52

Closed
wants to merge 5 commits into
from

Conversation

Projects
None yet
2 participants
@vanchi-zendesk
Contributor

vanchi-zendesk commented Feb 19, 2014

@zendesk/zendesk-radar
Currently WIP, will add more code to prune presences...

+ logging = require('minilog')('server_presence');
+
+var radarServerExpiry = 15*1000,
+ serverPresenceId, port, heartbeat,

This comment has been minimized.

@nherment

nherment Feb 20, 2014

Contributor

my 2cts is that we've been bit by using statically defined variables (serverPresenceId, port, heartbeat) in a node file except when it's a constant like radarServerExpiry is.

The alternative is to use a prototyped constructor.

@nherment

nherment Feb 20, 2014

Contributor

my 2cts is that we've been bit by using statically defined variables (serverPresenceId, port, heartbeat) in a node file except when it's a constant like radarServerExpiry is.

The alternative is to use a prototyped constructor.

This comment has been minimized.

@vanchi-zendesk

vanchi-zendesk Feb 20, 2014

Contributor

sure.

@vanchi-zendesk

vanchi-zendesk Feb 20, 2014

Contributor

sure.

@vanchi-zendesk

This comment has been minimized.

Show comment
Hide comment
@vanchi-zendesk

vanchi-zendesk Jul 12, 2014

Contributor

closed in favor of #85

Contributor

vanchi-zendesk commented Jul 12, 2014

closed in favor of #85

@vanchi-zendesk vanchi-zendesk deleted the vanchi/presence_pruning branch Jul 12, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment