From 3c6ad7a76e19323eca6840f77b5cc2025981a4f3 Mon Sep 17 00:00:00 2001 From: Amir Alavi Date: Thu, 16 Nov 2023 15:09:34 -0500 Subject: [PATCH] fix: ignore 'RecreatingFailedPod' event reason for StatefulSets due to bug in 1.27 --- plugins/kubernetes/app/models/kubernetes/resource_status.rb | 5 +++++ .../test/models/kubernetes/resource_status_test.rb | 6 ++++++ 2 files changed, 11 insertions(+) diff --git a/plugins/kubernetes/app/models/kubernetes/resource_status.rb b/plugins/kubernetes/app/models/kubernetes/resource_status.rb index 65d5bfecc6..8d4e5c1ff7 100644 --- a/plugins/kubernetes/app/models/kubernetes/resource_status.rb +++ b/plugins/kubernetes/app/models/kubernetes/resource_status.rb @@ -24,6 +24,11 @@ class ResourceStatus ], Service: [ "FailedToUpdateEndpointSlices" + ], + StatefulSet: [ + # Regression from k8s 1.27: https://github.com/kubernetes/kubernetes/pull/115331 + # Pending backport in: https://github.com/kubernetes/kubernetes/pull/121921 + "RecreatingFailedPod" ] }.freeze diff --git a/plugins/kubernetes/test/models/kubernetes/resource_status_test.rb b/plugins/kubernetes/test/models/kubernetes/resource_status_test.rb index 1eb7d4b8e1..31085df488 100644 --- a/plugins/kubernetes/test/models/kubernetes/resource_status_test.rb +++ b/plugins/kubernetes/test/models/kubernetes/resource_status_test.rb @@ -90,6 +90,12 @@ def expect_event_request(&block) expect_event_request { details.must_equal "Live" } end + it "ignores known bad events for statefulset" do + resource[:kind] = "StatefulSet" + events[0].merge!(type: "Warning", reason: "RecreatingFailedPod") + expect_event_request { details.must_equal "Live" } + end + describe "with bad event" do before { events[0].merge!(type: "Warning", reason: "Boom") }