Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PAAS-578 run clair for all builds #1529

Merged
merged 1 commit into from Dec 9, 2016
Merged

PAAS-578 run clair for all builds #1529

merged 1 commit into from Dec 9, 2016

Conversation

grosser
Copy link
Contributor

@grosser grosser commented Dec 8, 2016

@murat1985 @morten @irwaters

  • run clair after any kind of build is finished
  • extract command-executor for easier testing and reusability
  • extract clair logic for easier testing and reusability
  • pass all docker credentials to clair so ECR works
  • fixes around process timeout and killing

@grosser grosser force-pushed the grosser/var branch 2 times, most recently from f431f90 to e9d613d Compare December 9, 2016 00:07
logingood
logingood approved these changes Dec 9, 2016
View reviewed changes
Copy link
Contributor

@logingood logingood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am refactoring hyperclair right now, will paste comment upon completion. That could be merged anyways because hyperclair is not working anyway right now 👍

lib/samson/clair.rb
executable,
*project.docker_repo.split('/', 2),
docker_ref,
whitelist_env: ['DOCKER_REGISTRY_USER', 'DOCKER_REGISTRY_PASS', 'HOME', 'PATH'],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HOME wouldn't be required after DOCKER_REGISTRY_USER/PASS would be in use.

lib/samson/clair.rb
with_time do
Samson::CommandExecutor.execute(
executable,
*project.docker_repo.split('/', 2),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 ;) - reworking hyperclair to support / in the image part

@grosser grosser merged commit b171fea into master Dec 9, 2016
@grosser grosser deleted the grosser/var branch December 9, 2016 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@logingood logingood logingood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@grosser @logingood