Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add readonly mode to production console #3324

Merged
merged 1 commit into from Apr 20, 2019

Conversation

Projects
None yet
3 participants
@grosser
Copy link
Member

commented Apr 18, 2019

Alternative for #3323 which can lock up the whole DB

rails c
Loading development environment (Rails 5.2.2.1)
Running in readonly mode. Use Samson::ReadonlyDb.disable to switch to writable.
samson(readonly dev)> Samson::ReadonlyDb.disable
samson(dev)>

@zendesk/compute @zendesk/bre

@grosser grosser requested a review from zendesk/bre as a code owner Apr 18, 2019

Show resolved Hide resolved lib/samson/readonly_db.rb Outdated
@grosser

This comment has been minimized.

Copy link
Member Author

commented Apr 19, 2019

@grosser grosser force-pushed the grosser/readonly2 branch 2 times, most recently from e73b130 to 234d42b Apr 19, 2019

@adammw

This comment has been minimized.

Copy link
Contributor

commented Apr 19, 2019

not sure if possible, but I wonder if wrapping it in a transaction as well would make doubly-sure that nothing bad sneaks through...

@adammw

This comment has been minimized.

Copy link
Contributor

commented Apr 19, 2019

also does transactions still work in here, do you have to allow "START TRANSACTION" and "ROLLBACK"?

@adammw

adammw approved these changes Apr 19, 2019

@sathishavm
Copy link
Collaborator

left a comment

+1

@grosser

This comment has been minimized.

Copy link
Member Author

commented Apr 20, 2019

we decided against transactions in the sandbox PR because they can cause global blocking, so I don't want to bring them back

@grosser grosser force-pushed the grosser/readonly2 branch from 234d42b to 534681e Apr 20, 2019

@grosser grosser force-pushed the grosser/readonly2 branch from 534681e to afa18d2 Apr 20, 2019

@grosser grosser merged commit 7690167 into master Apr 20, 2019

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
Inclusive Language Check Inclusive Language Check
Details

@grosser grosser deleted the grosser/readonly2 branch Apr 20, 2019

@grosser

This comment has been minimized.

Copy link
Member Author

commented Apr 20, 2019

🍿 can't wait for this to blow up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.