Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stop using columns that we will remove shortly #3602

Closed
wants to merge 1 commit into from

Conversation

grosser
Copy link
Contributor

@grosser grosser commented Nov 4, 2019

Steps:

  • manually alter to remove not-null (will block all deploys)
ActiveRecord::Base.connection.execute "ALTER TABLE `kubernetes_release_docs` CHANGE `requests_cpu` `requests_cpu` decimal(6,2) DEFAULT NULL, CHANGE `requests_memory` `requests_memory` integer DEFAULT NULL"
  • deploy this
  • manually remove columns (will block all deploys)
ActiveRecord::Base.connection.execute "ALTER TABLE `kubernetes_release_docs` DROP COLUMN `requests_cpu`, DROP COLUMN `requests_memory`, DROP COLUMN `no_cpu_limit`"
  • deploy revert of this

/cc @zendesk/compute @zendesk/eng-productivity

@grosser grosser requested a review from a team as a code owner November 4, 2019 20:42
@uthark
Copy link
Contributor

uthark commented Nov 4, 2019

hopefully this will fix it.

@grosser
Copy link
Contributor Author

grosser commented Nov 4, 2019

... will just do the delete over the weekend and then restart ... no need to do 2 long alters 🤷‍♂

@grosser grosser closed this Nov 4, 2019
@grosser grosser deleted the grosser/columns branch November 4, 2019 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants