From 51bd74ca564fb84f5e0f9114440755d5d7b92339 Mon Sep 17 00:00:00 2001 From: Juan Carlos Pazmino Date: Thu, 24 May 2018 06:38:47 -0500 Subject: [PATCH 1/2] Add ability to enable/disable voting on Android --- .../src/main/java/com/zendesk/unity/ZDK_Plugin.java | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/android-plugin/src/main/java/com/zendesk/unity/ZDK_Plugin.java b/android-plugin/src/main/java/com/zendesk/unity/ZDK_Plugin.java index eb5bd7c..4768d3a 100644 --- a/android-plugin/src/main/java/com/zendesk/unity/ZDK_Plugin.java +++ b/android-plugin/src/main/java/com/zendesk/unity/ZDK_Plugin.java @@ -44,6 +44,9 @@ public class ZDK_Plugin extends UnityComponent { private static final int CONTACT_US_BUTTON_VISIBILITY_OFF = 0; private static final int CONTACT_US_BUTTON_VISIBILITY_ARTICLE_LIST_ONLY = 1; private static final int CONTACT_US_BUTTON_VISIBILITY_ARTICLE_LIST_ARTICLE_VIEW = 2; + + // Original behavior was to have article voting enabled + private boolean _articleVotingEnabled = true; public static ZDK_Plugin _instance; public static Object instance(){ @@ -124,6 +127,9 @@ public void setUserLocale(String locale) { } } + public void setArticleVotingEnabled(boolean enabled) { + _articleVotingEnabled = enabled; + } // ##### ##### ##### ##### ##### ##### ##### ##### // ZDKLogger @@ -231,7 +237,12 @@ public void viewArticle(final String id){ provider.getArticle(idLong, new ZendeskCallback
() { @Override public void onSuccess(Article article) { - ViewArticleActivity.startActivity(getActivity(), article); + ViewArticleActivity.startActivity( + getActivity(), + article, + true, // By default enable add ticket button, might allow customization later + null, // TODO: add further customization here + _articleVotingEnabled); } @Override From 0d8732676488653b5d3a034ba0c19e6d60544360 Mon Sep 17 00:00:00 2001 From: Juan Carlos Pazmino Date: Thu, 24 May 2018 10:13:03 -0500 Subject: [PATCH 2/2] Fix singleton issue --- .../src/main/java/com/zendesk/unity/ZDK_Plugin.java | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/android-plugin/src/main/java/com/zendesk/unity/ZDK_Plugin.java b/android-plugin/src/main/java/com/zendesk/unity/ZDK_Plugin.java index 4768d3a..f0c176f 100644 --- a/android-plugin/src/main/java/com/zendesk/unity/ZDK_Plugin.java +++ b/android-plugin/src/main/java/com/zendesk/unity/ZDK_Plugin.java @@ -50,7 +50,9 @@ public class ZDK_Plugin extends UnityComponent { public static ZDK_Plugin _instance; public static Object instance(){ - _instance = new ZDK_Plugin(); + if (_instance == null) { + _instance = new ZDK_Plugin(); + } return _instance; }