-
Notifications
You must be signed in to change notification settings - Fork 28
Increase promise timeout to 10 seconds #81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
6fad941 to
f24590a
Compare
hoangtrvu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than comment 👍
lib/client.js
Outdated
| var PROMISE_TIMEOUT = 5000 | ||
| // 5 seconds | ||
| var PROMISE_TIMEOUT = 10000 | ||
| // 10 seconds |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's reference the ticket here so we have some context if next time we consider changing this again.
Mehul-Porwal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 on 🍏
da5afde to
81fc76b
Compare
|
Hi @danielbreves @Mehul-Porwal -- when will this be rolled out? Coherence via ticket https://support.zendesk.com/agent/tickets/4058685 really wants this as soon as they can get it. I'm assuming, too, that existing zaf_sdk assets will be updated in place, correct? (IOW, Coherence won't have to reference a different SDK version or location) |
|
Hi @bryan-flynn-zd, yes that's correct, they won't have to update their reference to the SDK. We're trying to see if we could deploy this today. |
|
This PR was deployed to Static Assets Build. Reference: v2.0.22 |
|
This PR was deployed to Static Assets Switch Staging. Reference: v2.0.22 |
|
This PR was deployed to Static Assets Switch Major (v2). Reference: v2.0.22 |
|
Hi @hoangtrvu -- I see the deploy but when I look at the actual asset files, I still see the 5000ms timeout value in both the older and newer locations: Am I missing something? |
|
@bryan-flynn-zd I think it is just a browser cache. Opening it in incognito gives this: |
|
I see it now -- thanks @Mehul-Porwal ! |

@zendesk/vegemite
Increase promise timeout to 10 seconds to allow more time for requests to resolve. It seems especially during initialisation 5 seconds may not be enough for requests to complete when many apps are loading at the same time.
References
ZD#4058685
Risks
postMessageto never resolve it will take longer for the app to be able to handle the error.