fix(tooltips): fix rendering stutter in Safari #119
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since tooltips was one of our first usages of Popper.js the visibility logic was slightly different than Menus, Select, and other usages within the codebase. This difference causes a stutter effect for some renderings in Safari.
Detail
Previously, we handled visibility with a custom
aria-hiddenvalue to toggle the visibility on/off. This was originally for an accessibility requirement that was shown to not be needed in the recent Axe/Lighthouse walkthrough that I recently completed.This PR:
Thanks @zillding for finding this one!
Checklist
designer as a reviewer)
component
yarn start)src/index.jsexport