Skip to content

Conversation

@austingreendev
Copy link
Contributor

Description

Since tooltips was one of our first usages of Popper.js the visibility logic was slightly different than Menus, Select, and other usages within the codebase. This difference causes a stutter effect for some renderings in Safari.

Detail

Previously, we handled visibility with a custom aria-hidden value to toggle the visibility on/off. This was originally for an accessibility requirement that was shown to not be needed in the recent Axe/Lighthouse walkthrough that I recently completed.

This PR:

Thanks @zillding for finding this one!

Checklist

  • 👌 design updates are Garden Designer approved (add the
    designer as a reviewer)
  • 💅 view component styling is based on a Garden CSS
    component
  • 🌐 Styleguidist demo is up-to-date (yarn start)
  • ⬅️ renders as expected with reversed (RTL) direction
  • 💂‍♂️ includes new unit and snapshot tests
  • 📒 any new files are included in the packages src/index.js export
  • 📝 tested in Chrome, Firefox, Safari, Edge, and IE11

Copy link

@zillding zillding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 code looks fine.

as long as it works across browsers.

💯

@coveralls
Copy link

Pull Request Test Coverage Report for Build 477

  • 3 of 3 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.005%) to 96.169%

Totals Coverage Status
Change from base Build 468: 0.005%
Covered Lines: 1692
Relevant Lines: 1706

💛 - Coveralls

@austingreendev
Copy link
Contributor Author

as long as it works across browsers

Tested and working as expected without a stutter in all browsers

@austingreendev austingreendev merged commit 6203ec8 into master Aug 20, 2018
@austingreendev austingreendev deleted the agreen/tooltip-animation-fix branch August 20, 2018 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

5 participants