Skip to content

Conversation

@austingreendev
Copy link
Contributor

Description

With the changes to lerna --since that broke our publish process in Travis. This is a good excuse to upgrade these commands to a more "standard" lerna configuration.

Now that we no-longer have a custom npm publish process I've updated the travis command to use:

yarn lerna publish from-git --no-verify-access --yes

  • from-git
    • Will only publish if correctly tagged by Lerna (so no commit message check necessary)
  • --no-verify-access
    • This is a little sketchy, but it seems just setting the NPM _authToken doesn't allow Lerna to know a user is "logged in". If a user doesn't have access it would just fail on publish (same as before)
  • --yes
    • Skip confirmation prompts since we're in CI

Checklist

  • 👌 design updates are Garden Designer approved (add the
    designer as a reviewer)
  • 💅 view component styling is based on a Garden CSS
    component
  • 🌐 Styleguidist demo is up-to-date (yarn start)
  • ⬅️ renders as expected with reversed (RTL) direction
  • 💂‍♂️ includes new unit and snapshot tests
  • 📒 any new files are included in the packages src/index.js export
  • 📝 tested in Chrome, Firefox, Safari, Edge, and IE11

"plugin:jsx-a11y/recommended",
"prettier"
],
"settings": {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added due to some warnings after the ESLINT upgrade

@coveralls
Copy link

Pull Request Test Coverage Report for Build 533

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 96.124%

Totals Coverage Status
Change from base Build 531: 0.0%
Covered Lines: 1783
Relevant Lines: 1799

💛 - Coveralls

@austingreendev austingreendev merged commit 2a3bed3 into master Aug 23, 2018
@austingreendev austingreendev deleted the agreen/fix-lerna-publish branch August 23, 2018 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants