Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(forms): prevent validationLabel warning on Message when validation is undefined #1547

Merged
merged 2 commits into from
May 9, 2023
Merged

fix(forms): prevent validationLabel warning on Message when validation is undefined #1547

merged 2 commits into from
May 9, 2023

Conversation

jzempel
Copy link
Member

@jzempel jzempel commented May 9, 2023

Description

Adds a validation !== undefined condition to useText that prevents evaluation for a Message without validation treatment.

Detail

Updates react-theming peer dependency to v8.65.0 where the new condition parameter was added to useText.

@jzempel jzempel requested a review from a team as a code owner May 9, 2023 13:52
@coveralls
Copy link

Coverage Status

Coverage: 96.157% (+0.007%) from 96.15% when pulling 14e8cb4 on jzempel/usetext-condition into 6da7e4c on main.

@jzempel jzempel merged commit 6cdbddc into main May 9, 2023
@jzempel jzempel deleted the jzempel/usetext-condition branch May 9, 2023 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Francois-Esquire Francois-Esquire Francois-Esquire approved these changes

Assignees
No one assigned
Labels
PR: Bug Fix 🐛
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jzempel @coveralls @Francois-Esquire @zendesk-garden