Skip to content

Conversation

@austingreendev
Copy link
Contributor

Description

We currently don't allow consumers to spread props onto the Tab components that are created within Tabs.

This PR adds an optional tabProps attribute for these spreadable props. Since this surface area is shared with the TabPanel props we aren't able to spread like normal.

Checklist

  • 👌 design updates are Garden Designer approved (add the
    designer as a reviewer)
  • 💅 view component styling is based on a Garden CSS
    component
  • 🌐 Styleguidist demo is up-to-date (yarn start)
  • ⬅️ renders as expected with reversed (RTL) direction
  • 💂‍♂️ includes new unit and snapshot tests
  • 📒 any new files are included in the packages src/index.js export
  • 📝 tested in Chrome, Firefox, Safari, Edge, and IE11

@coveralls
Copy link

Coverage Status

Coverage increased (+0.001%) to 95.94% when pulling 3ab1d60 on agreen/tab-prop-spread into 8390d2e on master.

Copy link
Contributor

@ryanseddon ryanseddon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@austingreendev austingreendev merged commit 2c4f266 into master Oct 8, 2018
@austingreendev austingreendev deleted the agreen/tab-prop-spread branch October 8, 2018 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants