diff --git a/packages/tables/src/examples/overflow-menu.md b/packages/tables/src/examples/overflow-menu.md index ab1fda61323..e01dbb4139e 100644 --- a/packages/tables/src/examples/overflow-menu.md +++ b/packages/tables/src/examples/overflow-menu.md @@ -13,10 +13,11 @@ const { zdSpacingSm } = require('@zendeskgarden/css-variables'); const { Menu, Item } = require('@zendeskgarden/react-menus/src'); const { XL } = require('@zendeskgarden/react-typography/src'); -const OverflowMenu = ({ isHeader = false }) => ( +const OverflowMenu = () => ( alert(selectedKey)} placement="bottom-end" + style={{ marginTop: 0 }} popperModifiers={{ preventOverflow: { boundariesElement: 'viewport' @@ -27,10 +28,9 @@ const OverflowMenu = ({ isHeader = false }) => ( offset: { fn: data => { /** - * Have to ensure that popper is placed relative - * to the trigger + * Ensure correct placement relative to trigger **/ - data.offsets.popper.top -= isHeader ? 12 : 8; + data.offsets.popper.top -= 2; return data; } } diff --git a/packages/tables/src/views/Cell.js b/packages/tables/src/views/Cell.js index 6711e515e86..5d522edfcc6 100644 --- a/packages/tables/src/views/Cell.js +++ b/packages/tables/src/views/Cell.js @@ -28,7 +28,7 @@ const Cell = styled.div.attrs({ }) })` && { - display: block; + display: flex; width: ${({ width }) => width}; } diff --git a/packages/tables/src/views/HeaderRow.js b/packages/tables/src/views/HeaderRow.js index 7274961e8e4..b9459480342 100644 --- a/packages/tables/src/views/HeaderRow.js +++ b/packages/tables/src/views/HeaderRow.js @@ -10,6 +10,8 @@ import classNames from 'classnames'; import TableStyles from '@zendeskgarden/css-tables'; import { retrieveTheme } from '@zendeskgarden/react-theming'; +import { StyledOverflowButton } from './OverflowButton'; + const COMPONENT_ID = 'tables.header_row'; const HeaderRow = styled.div.attrs({ @@ -22,6 +24,12 @@ const HeaderRow = styled.div.attrs({ display: flex; } + /* stylelint-disable */ + ${StyledOverflowButton} { + margin-top: auto !important; + } + /* stylelint-enable */ + ${props => retrieveTheme(COMPONENT_ID, props)}; `; diff --git a/packages/tables/src/views/OverflowButton.js b/packages/tables/src/views/OverflowButton.js index ea4827dc705..93e39b0cc8a 100644 --- a/packages/tables/src/views/OverflowButton.js +++ b/packages/tables/src/views/OverflowButton.js @@ -18,7 +18,7 @@ const COMPONENT_ID = 'tables.overflow_button'; /** * Accepts all `