Skip to content

Conversation

@austingreendev
Copy link
Contributor

Description

screen shot 2018-10-16 at 2 48 45 pm

@vedranio found an issue when users choose to add disabled styling a <Button while also using the danger styling.

We should add some disabled logic checks to our conditional className logic.

Fixed Version

2018-10-16 09-46-52 2018-10-16 09_47_17

Checklist

  • 👌 design updates are Garden Designer approved (add the
    designer as a reviewer)
  • 💅 view component styling is based on a Garden CSS
    component
  • 🌐 Styleguidist demo is up-to-date (yarn start)
  • ⬅️ renders as expected with reversed (RTL) direction
  • 💂‍♂️ includes new unit and snapshot tests
  • 📒 any new files are included in the packages src/index.js export
  • 📝 tested in Chrome, Firefox, Safari, Edge, and IE11

@vedranio
Copy link

👍 for the design review

@austingreendev austingreendev merged commit 2ca8f2f into master Oct 17, 2018
@austingreendev austingreendev deleted the agreen/disabled-button-danger branch October 17, 2018 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

5 participants