Skip to content

fix(tags): update @zendeskgarden/css-tags #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix(tags): update @zendeskgarden/css-tags #199

wants to merge 1 commit into from

Conversation

@jzempel
Copy link
Member

@jzempel jzempel commented Oct 30, 2018

  • BREAKING CHANGE?

Description

... with fix for misspelled CSS variable.

Detail

zendeskgarden/css-components#139

Checklist

  • 👌 design updates are Garden Designer approved (add the
    designer as a reviewer)
  • 💅 view component styling is based on a Garden CSS
    component
  • 🌐 Styleguidist demo is up-to-date (yarn start)
  • ⬅️ renders as expected with reversed (RTL) direction
  • 💂‍♂️ includes new unit and snapshot tests
  • 📒 any new files are included in the packages src/index.js export
  • 📝 tested in Chrome, Firefox, Safari, Edge, and IE11

@jzempel jzempel requested a review from ryanseddon October 30, 2018 02:17
@coveralls
Copy link

coveralls commented Oct 30, 2018

Coverage Status

Coverage remained the same at 94.792% when pulling 10fef70 on jzempel/update-tags into 7e57c47 on master.

@jzempel
Copy link
Member Author

jzempel commented Oct 30, 2018

closed by #196

@jzempel jzempel closed this Oct 30, 2018
@jzempel jzempel deleted the jzempel/update-tags branch October 30, 2018 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ryanseddon ryanseddon Awaiting requested review from ryanseddon

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jzempel @coveralls