Skip to content

Conversation

@Fredx87
Copy link
Contributor

@Fredx87 Fredx87 commented Dec 2, 2025

Description

This PR fixes an issue with the Modal and the TooltipDialog component, which were not passing the document eventually provided in the Garden theme to the useModal hook.

Detail

This should improve the support for rendering modals inside a Shadow DOM element.

Closes #2058.

Checklist

  • 🌐 demo is up-to-date (npm start)
  • ⬅️ renders as expected with reversed (RTL) direction
  • ⚫ renders as expected in dark mode
  • 🤘 renders as expected with Bedrock CSS (?bedrock)
  • 💂‍♂️ includes new unit tests. Maintain existing coverage (always >= 96%)
  • ♿ tested for WCAG 2.1 AA accessibility compliance
  • 📝 tested in Chrome, Firefox, Safari, and Edge

Copy link
Member

@jzempel jzempel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for the contribution @Fredx87

@jzempel jzempel merged commit 23fa9b0 into main Dec 2, 2025
9 checks passed
@jzempel jzempel deleted the gianluca/modals-environment branch December 2, 2025 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

Modal and TooltipDialog don't pass environment to useModal hook

3 participants