From 7e0aecf1d61082012dc962028dd5ffceb01a2add Mon Sep 17 00:00:00 2001 From: Austin Green Date: Thu, 10 Jan 2019 09:33:27 -0800 Subject: [PATCH] fix(autocomplete|select): limit propTypes of maxHeight to string --- packages/autocomplete/src/elements/Autocomplete.js | 2 +- packages/select/src/elements/Select.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/autocomplete/src/elements/Autocomplete.js b/packages/autocomplete/src/elements/Autocomplete.js index c1541dc49a9..f9151a63e56 100644 --- a/packages/autocomplete/src/elements/Autocomplete.js +++ b/packages/autocomplete/src/elements/Autocomplete.js @@ -70,7 +70,7 @@ export default class Autocomplete extends Component { onChange: PropTypes.func, inputRef: PropTypes.func, placeholder: PropTypes.string, - maxHeight: PropTypes.oneOfType([PropTypes.number, PropTypes.string]), + maxHeight: PropTypes.string, disabled: PropTypes.bool, options: PropTypes.array.isRequired, noOptionsMessage: PropTypes.string, diff --git a/packages/select/src/elements/Select.js b/packages/select/src/elements/Select.js index 26d9d557649..bb99440d154 100644 --- a/packages/select/src/elements/Select.js +++ b/packages/select/src/elements/Select.js @@ -106,7 +106,7 @@ export default class Select extends ControlledComponent { /** * The max-height of the dropdown element */ - maxHeight: PropTypes.oneOfType([PropTypes.string, PropTypes.number]) + maxHeight: PropTypes.string }; static defaultProps = {