fix(buttons): Whitelist svg-icons so they get inlined correctly #282
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When we migrated to
@svgr/webpack
#221 we broke react-buttons as part of that change as we removedbabel-plugin-inline-react-svg
.Detail
Right now if you pull down the latest react-buttons package in something like codesandbox or as part of a create-react-app it'll throw about not finding an svg. See test case https://codesandbox.io/s/pjo7kk1lmj
We just need to whitelist svg-icons from externals so svgr can still inline it correctly.
fixes #281
Checklist