New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(loaders): introduce Inline component #289
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pre-published for review at https://garden.zendesk.com/react-components/loaders/ |
ryanseddon
approved these changes
Mar 15, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good only minor feedback
ryanseddon
reviewed
Mar 15, 2019
ginnywood
approved these changes
Mar 15, 2019
austingreendev
changed the title
feat(loaders): introduce TypingIndicator component
feat(loaders): introduce Inline component
Mar 15, 2019
allisonacs
approved these changes
Mar 15, 2019
jzempel
approved these changes
Mar 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is the v1 of a "vertical space neutral" typing indicator component. @allisonacs could you help me with the naming here? Not sure if we need to generalize this name for other uses in the future.
Detail
This component uses the CSS pulse animation from the original self-service implementation with the following changes:
ThemeProvider
Default size: 16px
Default color: grey-600
LTR
RTL
Accessibility
For loading indicators, the
aria-busy
andaria-live
attributes must be applied to containing elements and have to be managed by consumers (same as the other loading components).Checklist
designer as a reviewer)
💅 view component styling is based on a Garden CSScomponent
yarn start
)