Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(loaders): introduce Inline component #289

Merged
merged 5 commits into from Mar 16, 2019

Conversation

austingreendev
Copy link
Contributor

Description

This is the v1 of a "vertical space neutral" typing indicator component. @allisonacs could you help me with the naming here? Not sure if we need to generalize this name for other uses in the future.

Detail

This component uses the CSS pulse animation from the original self-service implementation with the following changes:

  • The SVG circles are now defaulted to 0.2 opacity to avoid a "flash of unstyled content"
  • It now supports RTL mode via our ThemeProvider
  • Size and color are now calculated in CSS-in-JS so can be provided via props

Default size: 16px
Default color: grey-600

LTR

TypingIndicatorLTR

RTL

TypingIndicatorRTL

Accessibility

For loading indicators, the aria-busy and aria-live attributes must be applied to containing elements and have to be managed by consumers (same as the other loading components).

Checklist

  • 👌 design updates are Garden Designer approved (add the
    designer as a reviewer)
  • 💅 view component styling is based on a Garden CSS
    component
  • 🌐 Styleguidist demo is up-to-date (yarn start)
  • ⬅️ renders as expected with reversed (RTL) direction
  • ♿ analyzed via axe and evaluated using VoiceOver
  • 💂‍♂️ includes new unit and snapshot tests
  • 📝 tested in Chrome, Firefox, Safari, Edge, and IE11

@austingreendev austingreendev requested review from allisonacs, ginnywood and a team March 14, 2019 23:38
@coveralls
Copy link

coveralls commented Mar 14, 2019

Coverage Status

Coverage increased (+0.03%) to 93.542% when pulling d301263 on agreen/typing-indicator into 218b0c2 on master.

@austingreendev
Copy link
Contributor Author

Pre-published for review at https://garden.zendesk.com/react-components/loaders/

Copy link
Contributor

@ryanseddon ryanseddon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good only minor feedback

packages/loaders/src/TypingIndicator.js Outdated Show resolved Hide resolved
packages/loaders/src/TypingIndicator.js Outdated Show resolved Hide resolved
@austingreendev austingreendev changed the title feat(loaders): introduce TypingIndicator component feat(loaders): introduce Inline component Mar 15, 2019
@austingreendev austingreendev merged commit dc67d4a into master Mar 16, 2019
@austingreendev austingreendev deleted the agreen/typing-indicator branch March 16, 2019 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants