New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mutable-content #56

Open
juliangut opened this Issue Jan 19, 2017 · 14 comments

Comments

Projects
None yet
5 participants
@juliangut

juliangut commented Jan 19, 2017

aps message parameter should have a mutable-content key (starting with iOS 10)

Right now it can be added by using a custom parameter but it would be better to have it in its own attribute (getter/setter)

@juliangut

This comment has been minimized.

Show comment
Hide comment
@juliangut

juliangut Jan 20, 2017

I've just noticed #53

juliangut commented Jan 20, 2017

I've just noticed #53

@lostincode

This comment has been minimized.

Show comment
Hide comment
@lostincode

lostincode Feb 4, 2017

@juliangut I think this has to be under the aps payload - so setting in custom will have no weight. #53 addresses this.

lostincode commented Feb 4, 2017

@juliangut I think this has to be under the aps payload - so setting in custom will have no weight. #53 addresses this.

@juliangut

This comment has been minimized.

Show comment
Hide comment
@juliangut

juliangut Feb 6, 2017

@lostincode you're right. #53 addresses it the correct way.

This package seems to move sooooo slowly, that PR is from Nov 9th 2016

juliangut commented Feb 6, 2017

@lostincode you're right. #53 addresses it the correct way.

This package seems to move sooooo slowly, that PR is from Nov 9th 2016

@lostincode

This comment has been minimized.

Show comment
Hide comment
@lostincode

lostincode Feb 7, 2017

@juliangut agreed. I hope someone will check it soon

lostincode commented Feb 7, 2017

@juliangut agreed. I hope someone will check it soon

@laurent35240

This comment has been minimized.

Show comment
Hide comment
@laurent35240

laurent35240 Apr 26, 2017

Does anybody have any news about when this PR will be validated?

laurent35240 commented Apr 26, 2017

Does anybody have any news about when this PR will be validated?

@fjalvarezdd

This comment has been minimized.

Show comment
Hide comment
@fjalvarezdd

fjalvarezdd May 17, 2017

Please I need this attribute to be sent. Does anybody have checked it ? Thanks in advance,

fjalvarezdd commented May 17, 2017

Please I need this attribute to be sent. Does anybody have checked it ? Thanks in advance,

@laurent35240

This comment has been minimized.

Show comment
Hide comment
@laurent35240

laurent35240 May 17, 2017

We used the forked project from the PR and it works fine for us.
So I guess you can use it too

laurent35240 commented May 17, 2017

We used the forked project from the PR and it works fine for us.
So I guess you can use it too

@fjalvarezdd

This comment has been minimized.

Show comment
Hide comment
@fjalvarezdd

fjalvarezdd May 17, 2017

Hello @laurent35240 thanks for your response.
The problem is that I'm using https://github.com/Ph3nol/NotificationPusher to wrap Zend APNS / GCM service so I can not use the forked repo.

Thanks

fjalvarezdd commented May 17, 2017

Hello @laurent35240 thanks for your response.
The problem is that I'm using https://github.com/Ph3nol/NotificationPusher to wrap Zend APNS / GCM service so I can not use the forked repo.

Thanks

@laurent35240

This comment has been minimized.

Show comment
Hide comment
@laurent35240

laurent35240 May 17, 2017

Yes we had exactly the same problem.
We ended up forking both repositories:
https://github.com/xofym/NotificationPusher
https://github.com/xofym/ZendService_Apple_Apns

And put this configuration in our composer.json file in order to use our forked version

{
    "minimum-stability": "dev",
    "prefer-stable": true,
    "require": {
        "sly/notification-pusher": "dev-mutable",,
        "zendframework/zendservice-apple-apns": "1.2.2"
    },
    "repositories": [
        {
            "type": "vcs",
            "url": "git@github.com:xofym/ZendService_Apple_Apns.git"
        },
        {
            "type": "vcs",
            "url": "git@github.com:xofym/NotificationPusher.git"
        }
    ]
}

I guess you can use the same configuration in your project

laurent35240 commented May 17, 2017

Yes we had exactly the same problem.
We ended up forking both repositories:
https://github.com/xofym/NotificationPusher
https://github.com/xofym/ZendService_Apple_Apns

And put this configuration in our composer.json file in order to use our forked version

{
    "minimum-stability": "dev",
    "prefer-stable": true,
    "require": {
        "sly/notification-pusher": "dev-mutable",,
        "zendframework/zendservice-apple-apns": "1.2.2"
    },
    "repositories": [
        {
            "type": "vcs",
            "url": "git@github.com:xofym/ZendService_Apple_Apns.git"
        },
        {
            "type": "vcs",
            "url": "git@github.com:xofym/NotificationPusher.git"
        }
    ]
}

I guess you can use the same configuration in your project

@fjalvarezdd

This comment has been minimized.

Show comment
Hide comment
@fjalvarezdd

fjalvarezdd May 17, 2017

@laurent35240 do you mind if I use your repo? That's exactly that we've in mind to do.

Thanks

fjalvarezdd commented May 17, 2017

@laurent35240 do you mind if I use your repo? That's exactly that we've in mind to do.

Thanks

@laurent35240

This comment has been minimized.

Show comment
Hide comment
@laurent35240

laurent35240 May 17, 2017

Sure you can use our repo.
That's why I gave you our configuration in fact ;-)

laurent35240 commented May 17, 2017

Sure you can use our repo.
That's why I gave you our configuration in fact ;-)

@fjalvarezdd

This comment has been minimized.

Show comment
Hide comment
@fjalvarezdd

fjalvarezdd May 17, 2017

Hello @laurent35240 . Really appreciate it. I've just pointed to your repo and everything works as expected.

Thank you so much!

fjalvarezdd commented May 17, 2017

Hello @laurent35240 . Really appreciate it. I've just pointed to your repo and everything works as expected.

Thank you so much!

@seyfer

This comment has been minimized.

Show comment
Hide comment
@seyfer

seyfer Sep 24, 2017

@laurent35240 why not make pull requests?

seyfer commented Sep 24, 2017

@laurent35240 why not make pull requests?

@laurent35240

This comment has been minimized.

Show comment
Hide comment
@laurent35240

laurent35240 Sep 25, 2017

@seyfer Because they already exist ;-)
They just take very long time to be validated (see #53)

laurent35240 commented Sep 25, 2017

@seyfer Because they already exist ;-)
They just take very long time to be validated (see #53)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment