PHP 7.2 + QA Tools #13
Conversation
- test with lowest/locked/latest dependencies - dropped HHVM support - added PHP 7.1 and 7.2 builds - disabled email notifications - use composer scripts - added composer.lock to the repository
- added coveralls configuration - updated PHPUnit configuration - moved all support documents into docs directory - added PR and ISSUE templates - added coveralls and travis build badges into README.md - updated LICENSE.md skeleton - updated composer.json skeleton - added .gitattributes and updated .gitignore
| $this->reCaptcha->verify('challenge', 'response'); | ||
| } | ||
|
|
||
| public function testVerifyWithMissingChallengeField() |
There was a problem hiding this comment.
This test is now removed as verify function has only one parameter - responseField.
| } | ||
|
|
||
| public function testVerifyWithMissingResponseField() | ||
| { | ||
| $this->reCaptcha->setSecretKey($this->secretKey); | ||
| $this->reCaptcha->setIp('127.0.0.1'); | ||
| $response = $this->reCaptcha->verify('challenge', ''); | ||
| $response = $this->reCaptcha->verify(null); |
There was a problem hiding this comment.
This test is still failing, doesn't matter what I set here always I'm not getting false status response.
I wonder how it passed with v3 release?
There was a problem hiding this comment.
I've done some research, and it appears that payloads to the API verification point expect:
{
"secret": "secret key",
"remoteip": "optional; IP address of user",
"response": "required: user response token verifying user on your site"
}What's interesting is that while "response" is required, it does not appear that the ReCAPTCHA API cares what the value is, just so long as it is present. As such, this test is essentially moot; it will always return with a "success": true so long as the API key is valid.
I'll remove this test during merge.
| @@ -241,6 +241,10 @@ public function getParams() | |||
| */ | |||
| public function getParam($key) | |||
| { | |||
| if (! isset($this->params[$key])) { | |||
There was a problem hiding this comment.
This condition is added to fix tests, previously there was typo in test methods, see: https://github.com/zendframework/ZendService_ReCaptcha/pull/13/files#diff-2e1212952b04d9b7cc6e538238eb2279L67
| @@ -300,6 +304,10 @@ public function getOptions() | |||
| */ | |||
| public function getOption($key) | |||
| { | |||
| if (! isset($this->options[$key])) { | |||
There is no any documentation in that directory and any other in that repo
PHP 7.2 + QA Tools Conflicts: test/ReCaptchaTest.php
|
Thanks, @webimpress! |
Please enable coveralls for the library