Skip to content
This repository has been archived by the owner on Jan 1, 2020. It is now read-only.

Commit

Permalink
Merge pull request #307 from Maks3w/Maks3w-patch-1
Browse files Browse the repository at this point in the history 
Application config with PHP 5.5 ::class style
  • Loading branch information
@Ocramius
Ocramius committed Sep 14, 2015
2 parents 5a7ef8d + 2c9e759 commit 6ba430f
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion module/Application/config/module.config.php
View file
Expand Up @@ -7,6 +7,8 @@
* @license http://framework.zend.com/license/new-bsd New BSD License
*/

namespace Application;

return array(
'router' => array(
'routes' => array(
Expand Down Expand Up @@ -73,7 +75,7 @@
),
'controllers' => array(
'invokables' => array(
'Application\Controller\Index' => 'Application\Controller\IndexController'
'Application\Controller\Index' => Controller\IndexController::class
),
),
'view_manager' => array(
Expand Down

13 comments on commit 6ba430f

@jokersoft
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After that commit I got
Parse error: syntax error, unexpected T_CLASS, expecting T_STRING or T_VARIABLE or '$' in ...module/Application/config/module.config.php on line 78
after fresh installation
php 5.3.29

@Ocramius
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jokersoft the requirement to run the skeleton is now PHP 5.5. Please note that existing apps are unaffected by this change.

@jokersoft
Copy link

@jokersoft jokersoft commented on 6ba430f Sep 28, 2015 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ocramius
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jokersoft which page? That needs updating: versions of zendframework below 2.5.0 are PHP 5.3 compatible.

@jokersoft
Copy link

@jokersoft jokersoft commented on 6ba430f Sep 28, 2015 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ocramius
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3.1) if you try "http://framework.zend.com/about/faq/" - "Zend Framework 2 is based on PHP 5.3. We expect to add support for PHP 5.4 once it starts to be adopted by the PHP community."

Opened zendframework/zf2-documentation#1516 to fix this

  1. Now, I am on github readme.md, still unsuspicious https://github.com/zendframework/ZendSkeletonApplication ..no php version mentioning.

Yeah, this is probably something that could be fixed in the README, but in general, composer.json dictates the dependencies in modern PHP packages - you can always refer to that file as authoritative source of truth when it comes to dependencies (what isn't in there is to be considered missing or a dependency-related bug)

Also, there were no warnings or something about my phpversion when I opened public\index.php

index.php acts post-installation: this sort of error is caught during composer installation.

I've opened #313 to address this, as it seems that you installed ZF2 without composer.

@jokersoft
Copy link

@jokersoft jokersoft commented on 6ba430f Sep 28, 2015 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ocramius
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jokersoft that seems weird: it should simply refuse to install, given that composer.json requires 5.5 or more...

@jokersoft
Copy link

@jokersoft jokersoft commented on 6ba430f Sep 28, 2015 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ocramius
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jokersoft is your PHP CLI the same as the one used for your http requests (presumably apache2/nginx + mod_php or fastcgi)?

@jokersoft
Copy link

@jokersoft jokersoft commented on 6ba430f Sep 28, 2015 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jokersoft
Copy link

@jokersoft jokersoft commented on 6ba430f Sep 28, 2015 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jokersoft
Copy link

@jokersoft jokersoft commented on 6ba430f Sep 28, 2015 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.