Skip to content
This repository was archived by the owner on Dec 6, 2019. It is now read-only.

Conversation

@Maks3w
Copy link
Member

@Maks3w Maks3w commented Apr 30, 2015

No description provided.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No; the phpunit.xml.dist file is in the root, and the test bootstrap is under test/. The original was correct.

@Maks3w
Copy link
Member Author

Maks3w commented Apr 30, 2015

IMO src and test should follow the same directory structure. So or both to have a subdirectory with the component name (redundant) or both should have the files directly in the src/test directory

@weierophinney
Copy link
Member

The problem is that we need the test bootstrap and test configuration, and the concern I have is with mixing those assets with the actual unit test classes.

I saw your recommendation that we move the test configuration into the phpunit.xml.dist as well, but that poses new problems, as it requires changes to the unit tests themselves. Since we're trying to keep history, that raises an issue with older versions of the tests no longer being executable.

If you can solve that problem, I'll happily make the directory structure change, as we can rename the Bootstrap.php file to bootstrap.php to avoid naming collisions.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants