New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing infos on zend-mvc-console #42

Merged
merged 6 commits into from Feb 4, 2019

Conversation

Projects
None yet
3 participants
@mdthh
Copy link
Contributor

mdthh commented Jan 23, 2019

Missing infos:

  • For MVC Routing zend-console needs zend-mvc-console
  • zend-mvc-console is deprecated!
    See also:
    #34
Missing infos on zend-mvc-console
Missiing infos:
* For MVC Routing zend-console needs zend-mvc-console
* zend-mvc-console is deprecated!
See also:
#34
@mdthh

This comment has been minimized.

Copy link
Contributor Author

mdthh commented Jan 29, 2019

Is there no interest at all in this proposed file change? :-(

@weierophinney

This comment has been minimized.

Copy link
Member

weierophinney commented Jan 29, 2019

@mdthh We have almost 200 repositories we maintain within the Zend Framework project. A little patience from contributors is required, as it takes time to triage and review patches for such a large project.

@@ -1,5 +1,8 @@
# MVC Routing

## Deprecated
For MVC routing zend-console is dependent on [zend-mvc-console](https://docs.zendframework.com/zend-mvc-console/) which will not be maintained long term. We strongly urge developers to start migrating their MVC-based console tooling to use other libraries, such as [zf-console](https://github.com/zfcampus/zf-console) from [Zend Framework Campus](https://github.com/zfcampus).

This comment has been minimized.

@weierophinney

weierophinney Jan 29, 2019

Member

I would link to symfony/console here, either in addition to or replacing the mention of zf-console. The reason is that we likely will not maintain any of our console tooling long-term, as there are more complete implementations available elsewhere.

This comment has been minimized.

@mdthh

mdthh Feb 3, 2019

Author Contributor

As is is now more clearer to me that both zend-console and zend-mvc-console are deprecated, I moved the Deprecated-Warning from the mvc-routing sub page in zend-console docs right in to the introduction of zend-console.

Plus, I added the link to symfony/console as suggested by @weierophinney .

Generally speaking, wouldn't be good to have a more flashy warning if a component is deprecated? A warning that is highlighted in some way and posted at the beginning of each documentation page of an affected component. In my case I would have used symfony/console right away and saved a lot of work if the docs would have been clearer.

Perhaps a warning similar as it is placed now on the old docs?

bildschirmfoto_2019-02-03_11-28-18

This comment has been minimized.

@froschdesign

froschdesign Feb 3, 2019

Member

@mdthh

Generally speaking, wouldn't be good to have a more flashy warning if a component is deprecated?

See my comment to the format.

Perhaps a warning similar as it is placed now on the old docs?

It is already planned but not yet available.

This comment has been minimized.

@mdthh

mdthh Feb 3, 2019

Author Contributor

@froschdesign

It is already planned but not yet available.

I would like to offer my participation, if desired. Just tell me in what way I could assist.

mdthh added some commits Feb 3, 2019

Show resolved Hide resolved docs/book/intro.md Outdated
Show resolved Hide resolved docs/book/intro.md Outdated

mdthh added some commits Feb 3, 2019

Show resolved Hide resolved docs/book/intro.md Outdated

@weierophinney weierophinney merged commit c435570 into zendframework:master Feb 4, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 61.528%
Details

weierophinney added a commit that referenced this pull request Feb 4, 2019

weierophinney added a commit that referenced this pull request Feb 4, 2019

weierophinney added a commit that referenced this pull request Feb 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment