New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support dash on MySQL identifier #271

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@WellingGuzman
Contributor

WellingGuzman commented Oct 7, 2017

On MySQL trying to select a column/table with dash in its name result in a error.

Ref #208

@mwillbanks

This comment has been minimized.

Show comment
Hide comment
@mwillbanks

mwillbanks Oct 20, 2017

Contributor

Dashes are horribly bad practice in identifiers for mysql, however, it is documented explicitly in https://dev.mysql.com/doc/refman/5.7/en/identifier-qualifiers.html therefore I can approve this PR.

Contributor

mwillbanks commented Oct 20, 2017

Dashes are horribly bad practice in identifiers for mysql, however, it is documented explicitly in https://dev.mysql.com/doc/refman/5.7/en/identifier-qualifiers.html therefore I can approve this PR.

@ezimuel

This comment has been minimized.

Show comment
Hide comment
@ezimuel

ezimuel Nov 23, 2017

Member

@WellingGuzman I merged this in develop since it's a new feature. Thanks for your contribution!

Member

ezimuel commented Nov 23, 2017

@WellingGuzman I merged this in develop since it's a new feature. Thanks for your contribution!

@ezimuel ezimuel closed this Nov 23, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment