Change Return Type in selectWith() method

[lowtower]

Change Return Type of selectWith() method

Provide a narrative description of what you are trying to accomplish:

• Are you fixing a bug?
  • Detail how the bug is invoked currently.

phpstan raises an error saying that ResulSetInterface has no method current().

• Detail the original, incorrect behavior.

The selectWith() method has defined the @returnType as ResultSetInterface.
The method calls the method executeSelect(), which returns ResultSet.
The return types should be the same.
removes also the @throws flag as it doesn't throw an exception itself, but just the called methods.

• Detail the new, expected behavior.

• Base your feature on the master branch, and submit against that branch.

• Add a regression test that demonstrates the bug, and proves the fix.

• Add a CHANGELOG.md entry for the fix.

• Are you creating a new feature?

  • Why is the new feature needed? What purpose does it serve?
  • How will users use the new feature?
  • Base your feature on the develop branch, and submit against that branch.
  • Add only one feature per pull request; split multiple features over multiple pull requests
  • Add tests for the new feature.
  • Add documentation for the new feature.
  • Add a CHANGELOG.md entry for the new feature.

• Is this related to quality assurance?

• Is this related to documentation?

[tptrixtop]

May be use then AbstractResultSet in lieu of ResultSet ?

[samsonasik]

selectWith() can return HydratingResultSet, so AbstractResultSet is better.

[lowtower]

Then select(), selectWith() and executeSelect() should all return AbstractResultSet.
Right?

[samsonasik]

yes

[froschdesign]

Why AbstractResultSet? Compare with:

zend-db/src/TableGateway/AbstractTableGateway.php

Lines 58 to 61 in adfe190

	/**
	* @var ResultSetInterface
	*/
	protected $resultSetPrototype = null;

zend-db/src/TableGateway/AbstractTableGateway.php

Lines 109 to 111 in adfe190

	if (! $this->resultSetPrototype instanceof ResultSetInterface) {
	$this->resultSetPrototype = new ResultSet;
	}

zend-db/src/TableGateway/AbstractTableGateway.php

Lines 241 to 248 in adfe190

	// build result set
	$resultSet = clone $this->resultSetPrototype;
	$resultSet->initialize($result);
	// apply postSelect features
	$this->featureSet->apply(EventFeatureEventsInterface::EVENT_POST_SELECT, [$statement, $result, $resultSet]);
	return $resultSet;

[samsonasik]

missing use statement:

use Zend\Db\ResultSet\AbstractResultSet;

[samsonasik]

@froschdesign how about using @var ResultSetInterface|AbstractResultSet for $resultSetPrototype property ?

[lowtower]

@froschdesign
indeed, not consistant!
What do you propose?

[ezimuel]

@samsonasik Zend\Db\ResultSet\AbstractResultSet implements Zend\Db\ResultSet\ResultSetInterface, it's better to use this interface as return type.
@lowtower can you propose a new PR chaning all the types to ResultSetInterface? Thanks!
I'm closing this PR in favor of a new one.