Skip to content
This repository was archived by the owner on Jan 29, 2020. It is now read-only.

Change Return Type in selectWith() method #312

Closed
lowtower wants to merge 4 commits into from
Closed

Change Return Type in selectWith() method #312

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9825a1d
Update AbstractTableGateway.php
lowtower Apr 11, 2018
78377c7
@return AbstractResultSet
lowtower Apr 11, 2018
96a8632
Add missing use statement
lowtower Apr 11, 2018
fa22d52
Change type of $resultSetPrototype as suggested by @samsonasik
lowtower Apr 13, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/TableGateway/AbstractTableGateway.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
namespace Zend\Db\TableGateway;

use Zend\Db\Adapter\AdapterInterface;
use Zend\Db\ResultSet\AbstractResultSet;
use Zend\Db\ResultSet\ResultSet;
use Zend\Db\ResultSet\ResultSetInterface;
use Zend\Db\Sql\Delete;
Expand Down Expand Up @@ -56,7 +57,7 @@ abstract class AbstractTableGateway implements TableGatewayInterface
protected $featureSet = null;

/**
* @var ResultSetInterface
* @var ResultSetInterface|AbstractResultSet
*/
protected $resultSetPrototype = null;

Expand Down Expand Up @@ -177,7 +178,7 @@ public function getSql()
* Select
*
* @param Where|\Closure|string|array $where
* @return ResultSet
* @return AbstractResultSet
*/
public function select($where = null)
{
Expand All @@ -198,8 +199,7 @@ public function select($where = null)

/**
* @param Select $select
* @return ResultSetInterface
* @throws \RuntimeException
* @return AbstractResultSet
*/
public function selectWith(Select $select)
{
Expand All @@ -211,7 +211,7 @@ public function selectWith(Select $select)

/**
* @param Select $select
* @return ResultSet
* @return AbstractResultSet
* @throws Exception\RuntimeException
*/
protected function executeSelect(Select $select)
Expand Down