Skip to content
This repository has been archived by the owner on Jan 29, 2020. It is now read-only.

1. add return statement to Adapter::getHelpers method; #319

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

1. add return statement to Adapter::getHelpers method; #319

wants to merge 1 commit into from

Conversation

darluc
Copy link

@darluc darluc commented Jun 8, 2018

Class Zend\Db\Adapter\Adapter method getHelpers, you guys forget to return the $functions

  • Are you fixing a bug?
    • Detail how the bug is invoked currently.
    • Detail the original, incorrect behavior.
    • Detail the new, expected behavior.
    • Base your feature on the master branch, and submit against that branch.
    • Add a regression test that demonstrates the bug, and proves the fix.
    • Add a CHANGELOG.md entry for the fix.

@malukenho
Copy link
Member

@darluc you should probably provide a unit test that reproduces the bug as well.

@darluc
Copy link
Author

darluc commented Jun 9, 2018

@malukenho okay, I'll try.

@weierophinney
Copy link
Member

This repository has been moved to laminas/laminas-db. If you feel that this patch is still relevant, please re-open against that repository, and reference this issue. To re-open, we suggest the following workflow:

  • Squash all commits in your branch (git rebase -i origin/{branch})
  • Make a note of all changed files (`git diff --name-only origin/{branch}...HEAD
  • Run the laminas/laminas-migration tool on the code.
  • Clone laminas/laminas-db to another directory.
  • Copy the files from the second bullet point to the clone of laminas/laminas-db.
  • In your clone of laminas/laminas-db, commit the files, push to your fork, and open the new PR.
    We will be providing tooling via laminas/laminas-migration soon to help automate the process.

@michalbundyra
Copy link
Member

This repository has been closed and moved to laminas/laminas-db; a new issue has been opened at laminas/laminas-db#49.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants