New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeError: toggleTrigger is null toggleTrigger.innerHTML = "◄"; #155

Open
sjanjic opened this Issue Jun 23, 2014 · 9 comments

Comments

Projects
None yet
2 participants
@sjanjic

sjanjic commented Jun 23, 2014

Firebug show this error on this function:

        self.show = function() {
            slide(0);

            toggleTrigger.innerHTML = "";
            toggleTrigger.setAttribute("title", "Hide Toolbar");
            hidden = false;

            cookie.set(cookieKeyHidden, 0);
        };

and there is no icon to close toolbar

@Ocramius

This comment has been minimized.

Show comment
Hide comment
@Ocramius

Ocramius Jun 23, 2014

Member

What's the error?

Member

Ocramius commented Jun 23, 2014

What's the error?

@sjanjic

This comment has been minimized.

Show comment
Hide comment
@sjanjic

sjanjic Jun 23, 2014

In javascript, firebug report error

sjanjic commented Jun 23, 2014

In javascript, firebug report error

@Ocramius

This comment has been minimized.

Show comment
Hide comment
@Ocramius

Ocramius Jun 23, 2014

Member

Yes, but what error?

Member

Ocramius commented Jun 23, 2014

Yes, but what error?

@sjanjic

This comment has been minimized.

Show comment
Hide comment
@sjanjic

sjanjic Jun 23, 2014

TypeError: toggleTrigger is null

toggleTrigger.innerHTML = "◄";

sjanjic commented Jun 23, 2014

TypeError: toggleTrigger is null

toggleTrigger.innerHTML = "◄";

@Ocramius

This comment has been minimized.

Show comment
Hide comment
@Ocramius

Ocramius Jun 23, 2014

Member

What does this look like in your page?

Member

Ocramius commented Jun 23, 2014

What does this look like in your page?

@sjanjic

This comment has been minimized.

Show comment
Hide comment
@sjanjic

sjanjic Jun 23, 2014

How to test it?

sjanjic commented Jun 23, 2014

How to test it?

@Ocramius

This comment has been minimized.

Show comment
Hide comment
@Ocramius

Ocramius Jun 23, 2014

Member

Just run that command in the console - I suppose the HTML on your page may be broken

Member

Ocramius commented Jun 23, 2014

Just run that command in the console - I suppose the HTML on your page may be broken

@sjanjic

This comment has been minimized.

Show comment
Hide comment
@sjanjic

sjanjic Jun 23, 2014

It shows a element with 'zdf-toolbar-toggle' id but it's hidden

sjanjic commented Jun 23, 2014

It shows a element with 'zdf-toolbar-toggle' id but it's hidden

@sjanjic

This comment has been minimized.

Show comment
Hide comment
@sjanjic

sjanjic Jun 23, 2014

<a href="javascript:void(0);" class="zdf-toolbar-hide-button" id="zdf-toolbar-toggle"></a>

sjanjic commented Jun 23, 2014

<a href="javascript:void(0);" class="zdf-toolbar-hide-button" id="zdf-toolbar-toggle"></a>

@sjanjic sjanjic closed this Jun 23, 2014

@sjanjic sjanjic reopened this Jun 23, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment