New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New coding standard #21

Merged
merged 9 commits into from Nov 14, 2017

Conversation

Projects
None yet
2 participants
@Koopzington
Contributor

Koopzington commented Nov 13, 2016

Usage of the newly introduced zendframework/zend-coding-standard for CS checks.

@Koopzington

This comment has been minimized.

Show comment
Hide comment
@Koopzington

Koopzington Nov 19, 2016

Contributor

PR failing because PHP 5.5 doesn't like class properties splitted across multiple lines.
Fixable by merging #20

Contributor

Koopzington commented Nov 19, 2016

PR failing because PHP 5.5 doesn't like class properties splitted across multiple lines.
Fixable by merging #20

@weierophinney weierophinney merged commit e2fef6c into zendframework:master Nov 14, 2017

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details

weierophinney added a commit that referenced this pull request Nov 14, 2017

Merge pull request #21 from Koopzington/new-coding-standard
New coding standard

Conflicts:
	.travis.yml
	composer.json

weierophinney added a commit that referenced this pull request Nov 14, 2017

weierophinney added a commit that referenced this pull request Nov 14, 2017

Merge branch 'hotfix/21' into develop
Forward port #21

Conflicts:
	src/DefinitionList.php
@weierophinney

This comment has been minimized.

Show comment
Hide comment
@weierophinney
Member

weierophinney commented Nov 14, 2017

Thanks, @Koopzington

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment