This repository has been archived by the owner on Jan 29, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@waahhhh Thanks for your contribution. We can't accept this PR as it is - it contains BC Break (bump PHP version, by us considered as BC Break and can be released only with new major version) and Bugfix for PHP 7.4 compatibility. Please provide bugfix separately - PR to master, and then other PR with bumped PHP version to develop. Thanks! |
Removed version bump and changed |
8000b75
to
f37b81c
Compare
Add conflict with prophecy version prior to 1.9.0 for PHP 7.4 compatibility
It is not working for the lowest deps as we still have zend-stdlib v2 in allowed dependencies. It is not compatible with PHP 7.3+.
michalbundyra
added a commit
that referenced
this pull request
Dec 10, 2019
Hotfix: PHP 7.4 compatibility
Thanks, @waahhhh! |
8 tasks
This PR does not pass static analysis. Why didn't this PR trigger a travis build? |
@tux-rampage PR was to master, was merged as a hotfix. |
I see, thanks |
tux-rampage
added a commit
to tux-rampage/zend-di
that referenced
this pull request
Dec 16, 2019
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide a narrative description of what you are trying to accomplish:
But that will be resolved by: #47
Are you fixing a bug?
master
branch, and submit against that branch.CHANGELOG.md
entry for the fix.Are you creating a new feature?
develop
branch, and submit against that branch.CHANGELOG.md
entry for the new feature.Is this related to quality assurance?