New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed authorization link #19

Merged
merged 1 commit into from Jan 10, 2019

Conversation

Projects
None yet
3 participants
@tomtomsen
Copy link
Contributor

tomtomsen commented Jan 10, 2019

Provide a narrative description of what you are trying to accomplish:

  • Are you fixing a bug?

    • Detail how the bug is invoked currently.
    • Detail the original, incorrect behavior.
    • Detail the new, expected behavior.
    • Base your feature on the master branch, and submit against that branch.
    • Add a regression test that demonstrates the bug, and proves the fix.
    • Add a CHANGELOG.md entry for the fix.
  • Are you creating a new feature?

    • Why is the new feature needed? What purpose does it serve?
    • How will users use the new feature?
    • Base your feature on the develop branch, and submit against that branch.
    • Add only one feature per pull request; split multiple features over multiple pull requests
    • Add tests for the new feature.
    • Add documentation for the new feature.
    • Add a CHANGELOG.md entry for the new feature.
  • Is this related to quality assurance?

  • Is this related to documentation?
    it sems like authentication and authorization got mixed up

@webimpress
Copy link
Contributor

webimpress left a comment

LGTM 👍

@weierophinney weierophinney merged commit 283219b into zendframework:master Jan 10, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 88.235%
Details

weierophinney added a commit that referenced this pull request Jan 10, 2019

weierophinney added a commit that referenced this pull request Jan 10, 2019

@weierophinney

This comment has been minimized.

Copy link
Member

weierophinney commented Jan 10, 2019

Thanks, @tomtomsen!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment