This repository has been archived by the owner on Jan 21, 2020. It is now read-only.
Ensure invalid extension types result in InvalidExtensionException #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a test for the fix originally provided in zendframework#9, and an additional test for cases where a non-service class name was provided; each should raise the exception, in order to prevent a `TypeError` (PHP 7) or fatal error (PHP 5) from occurring instead. Revised the logic to prevent duplication of the check against `ExtensionInterface`.
weierophinney
added a commit
that referenced
this pull request
Jan 11, 2017
weierophinney
added a commit
that referenced
this pull request
Jan 11, 2017
weierophinney
added a commit
that referenced
this pull request
Jan 11, 2017
Forward port #13 Conflicts: CHANGELOG.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch extends on #9, adding tests, and a further check for invalid non-service extension class names.
At this point, an
InvalidExtensionExceptionis raised if:ExtensionInterface, whether that instance is pulled from the container or instantiated directly.