From 79573739167b20667655e900d99945bdafdb91ea Mon Sep 17 00:00:00 2001 From: Filippo Tessarotto Date: Mon, 17 Dec 2018 17:05:56 +0100 Subject: [PATCH 1/2] RenameUploadTest: better test names --- test/File/RenameUploadTest.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/File/RenameUploadTest.php b/test/File/RenameUploadTest.php index a4eb5e13..d98eb607 100644 --- a/test/File/RenameUploadTest.php +++ b/test/File/RenameUploadTest.php @@ -417,7 +417,7 @@ public function testReturnUnfiltered($input) * @see https://github.com/zendframework/zend-filter/issues/77 * @return void */ - public function testCachesResultsOfFilteringSAPIUploads() + public function testFilterDoesNotAlterUnkownFileDataAndCachesResultsOfFilteringSAPIUploads() { $filter = new RenameUploadMock($this->targetPath); @@ -447,7 +447,7 @@ public function testCachesResultsOfFilteringSAPIUploads() * @see https://github.com/zendframework/zend-filter/issues/76 * @return void */ - public function testFilterReturnsFileDataVerbatimUnderSAPIWhenNameAndTmpNameDiffer() + public function testFilterReturnsFileDataVerbatimUnderSAPIWhenNameAndTmpNameDoNotDiffer() { $filter = new RenameUploadMock(); From e79933d93e84aa7af39628ad141e0e58eff6a0dc Mon Sep 17 00:00:00 2001 From: Filippo Tessarotto Date: Tue, 18 Dec 2018 17:05:07 +0100 Subject: [PATCH 2/2] Better description as test name --- test/File/RenameUploadTest.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/File/RenameUploadTest.php b/test/File/RenameUploadTest.php index d98eb607..9e601ba0 100644 --- a/test/File/RenameUploadTest.php +++ b/test/File/RenameUploadTest.php @@ -447,7 +447,7 @@ public function testFilterDoesNotAlterUnkownFileDataAndCachesResultsOfFilteringS * @see https://github.com/zendframework/zend-filter/issues/76 * @return void */ - public function testFilterReturnsFileDataVerbatimUnderSAPIWhenNameAndTmpNameDoNotDiffer() + public function testFilterReturnsFileDataVerbatimUnderSAPIWhenTargetPathIsUnspecified() { $filter = new RenameUploadMock();