This repository was archived by the owner on Jan 30, 2020. It is now read-only.
reduce getHeaders() call in Request::setServer() #183
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
samsonasik
commented
Aug 18, 2019
samsonasik
commented
- Is this related to quality assurance?
src/PhpEnvironment/Request.php
Outdated
| } | ||
|
|
||
| $this->getHeaders()->addHeaders($headers); | ||
| $headers = $this->getHeaders()->addHeaders($headers); |
Member
There was a problem hiding this comment.
Personally I am not sure if it is good improvement, I mean, for me it is less readable - as definition of the variable and usage of it is several lines below.
Also it takes advantages of fluent interfaces, and as far as I know we tend to drop them.
Contributor
Author
There was a problem hiding this comment.
Ok, I reverted the change of re-assignment headers.
src/PhpEnvironment/Request.php
Outdated
| // Set the host | ||
| if ($this->getHeaders()->get('host')) { | ||
| $host = $this->getHeaders()->get('host')->getFieldValue(); | ||
| if ($headers->get('host')) { |
Member
There was a problem hiding this comment.
We have then twice ->get('host').
What about:
$headerHost = $this->getHeaders()->get('host');
if ($headerHost) {
$host = $headerHost->getFieldValue();
...
Contributor
Author
There was a problem hiding this comment.
Ok, implemented assign first to $headerHost
michalbundyra
approved these changes
Sep 26, 2019
Member
|
Thanks, @samsonasik! |
michalbundyra
added a commit
that referenced
this pull request
Sep 26, 2019
reduce getHeaders() call in Request::setServer()
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.