This repository was archived by the owner on Jan 29, 2020. It is now read-only.
[WIP] AssetsListener #216
Closed
[WIP] AssetsListener #216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asgrim
reviewed
Feb 25, 2017
| * Zend Framework (http://framework.zend.com/) | ||
| * | ||
| * @link http://github.com/zendframework/zf2 for the canonical source repository | ||
| * @copyright Copyright (c) 2005-2015 Zend Technologies USA Inc. (http://www.zend.com) |
| */ | ||
| protected $filterManager; | ||
|
|
||
| protected $request; |
|
|
||
| protected $request; | ||
|
|
||
| protected $routeName = 'assets'; |
|
|
||
| protected $routeName = 'assets'; | ||
|
|
||
| protected $routerCacheFolder = 'assets'; |
|
|
||
| protected $routerCacheFolder = 'assets'; | ||
|
|
||
| protected $useInternalRouter = true; |
| return $response; | ||
| } | ||
|
|
||
| protected function filter(MvcEvent $event, $assetFile, $assetItem) |
| return $assetContent; | ||
| } | ||
|
|
||
| protected function cache(MvcEvent $event, $source) |
| * @param array|RouteStackInterface $router | ||
| * @return self | ||
| */ | ||
| public function setRouter($router) |
Contributor
There was a problem hiding this comment.
In what cases would an array be a suitable router? Shouldn't just requiring an interface be a requirement?
| */ | ||
| public function getAssetsResolver() | ||
| { | ||
| return $this->assetsResolver; |
Contributor
There was a problem hiding this comment.
What happens if $this->assetsResolver is not set?
| */ | ||
| public function getFilterManager() | ||
| { | ||
| return $this->filterManager; |
Contributor
There was a problem hiding this comment.
What if $this->filterManager is not set?
Member
|
I am going to close this PR now due to lack of activity. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow to use assets (css, js etc.) from modules, or other not public folders
Web server has not access to module folder directly, but this is possible through
AssetsListener.Zend\View\Helper\Assetshelper can build link to module folder (through Router),AssetsListenercan detect this link (through Router too) and route it to module name and asset.When
AssetsListenerdetected asset link, it caching module asset to public folder andbrowser can request this asset directly from public folder (it can be disabled).
Also
AssetsListenercan filter assets content, as sample .less to .css.This is extention for zendframework/zend-view#106