This repository was archived by the owner on Jan 31, 2020. It is now read-only.
PHP 7 requires return of a string in any case #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xistence of data. Fixes zendframework#35.
| $cacheStorage->getItem('242')->willReturn(null); | ||
| $this->usedSaveHandlers[] = $saveHandler = new Cache($cacheStorage->reveal()); | ||
|
|
||
| $id = '242'; |
Contributor
Author
There was a problem hiding this comment.
No, the session handler interface defines strings (session id).
Contributor
There was a problem hiding this comment.
yes, but the tests is not proving the (string) cast then, as 242 must be string, and 242 is not string.
Contributor
Author
There was a problem hiding this comment.
Casting is not necessary. It is a string because of the quotes (is_string('242') === true). The contents of the string is not of importance here.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
readreturns anything else than a string it will fail withPHP Catchable fatal error: session_regenerate_id(): Failed to create(read) session ID: user.PHP 7 requires that reading always returns a string, regardless the existence of data.
Fixes #35.
Might cover #41 as well.